Changeset 79346 in vbox

Timestamp:

Jun 26, 2019 9:13:37 AM (5 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Nested VMX: bugref:9180 Comment nits.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -16561 +16561 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS(pVCpu, pVmxTransient);
 
+    /*
+     * Strictly speaking we should not get VMREAD VM-exits for shadow VMCS fields and
+     * thus might not need to import the shadow VMCS state, it's safer just in case
+     * code elsewhere dares look at unsynced VMCS fields.
+     */
     int rc = hmR0VmxReadExitInstrLenVmcs(pVmxTransient);
     rc    |= hmR0VmxImportGuestState(pVCpu, pVmxTransient->pVmcsInfo, CPUMCTX_EXTRN_RSP | CPUMCTX_EXTRN_SREG_MASK
@@ -16628 +16633 @@
     /*
      * Although we should not get VMWRITE VM-exits for shadow VMCS fields, since
-     * our HM hook that gets invoked when IEM's VMWRITE instruction emulation
-     * modifies the current VMCS signals re-loading the entire shadow VMCS, we
-     * should also save the entire shadow VMCS here.
+     * our HM hook gets invoked when IEM's VMWRITE instruction emulation modifies
+     * the current VMCS signals re-loading the entire shadow VMCS, we should also
+     * save the entire shadow VMCS here.
      */
     int rc = hmR0VmxReadExitInstrLenVmcs(pVmxTransient);