Changeset 79363 in vbox for trunk

Timestamp:

Jun 26, 2019 3:25:43 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131596

Message:

Frontends/VBoxManage: Fix configuring the recording feature. It errored out due to using the wrong machine object. Restore the old command as an alias, it doesn't cost much and avoids annoying users who use the command to enable recording which worked in 5.2.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageControlVM.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageControlVM.cpp

@@ -1649 +1649 @@
             else
                 uuid = Guid().toString();
-            CHECK_ERROR(machine, MountMedium(Bstr("IDE Controller"), 1, 0, uuid, FALSE /* aForce */));
+            CHECK_ERROR(sessionMachine, MountMedium(Bstr("IDE Controller"), 1, 0, uuid, FALSE /* aForce */));
         }
         else if (!strcmp(a->argv[1], "floppyattach"))
@@ -1705 +1705 @@
             }
             floppyMedium->COMGETTER(Id)(uuid.asOutParam());
-            CHECK_ERROR(machine, MountMedium(Bstr("Floppy Controller"), 0, 0, uuid, FALSE /* aForce */));
+            CHECK_ERROR(sessionMachine, MountMedium(Bstr("Floppy Controller"), 0, 0, uuid, FALSE /* aForce */));
         }
 #endif /* obsolete dvdattach/floppyattach */
@@ -1855 +1855 @@
         }
 #ifdef VBOX_WITH_RECORDING
-        else if (!strcmp(a->argv[1], "recording"))
+        else if (   !strcmp(a->argv[1], "recording")
+                 || !strcmp(a->argv[1], "videocap") /* legacy command */)
         {
             if (a->argc < 3)
@@ -1865 +1866 @@
 
             ComPtr<IRecordingSettings> recordingSettings;
-            CHECK_ERROR_BREAK(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
+            CHECK_ERROR_BREAK(sessionMachine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
 
             SafeIfaceArray <IRecordingScreenSettings> saRecordingScreenScreens;
@@ -1887 +1888 @@
             {
                 ULONG cMonitors = 64;
-                CHECK_ERROR_BREAK(machine, COMGETTER(MonitorCount)(&cMonitors));
+                CHECK_ERROR_BREAK(sessionMachine, COMGETTER(MonitorCount)(&cMonitors));
                 com::SafeArray<BOOL> saScreens(cMonitors);
                 if (   a->argc == 4