Changeset 79430 in vbox for trunk/src/VBox

Timestamp:

Jul 1, 2019 6:01:52 AM (6 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Nested VMX: bugref:9180 Add todo regarding failed attempt at mapping the HC APIC-access page from ring-3.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -10958 +10958 @@
     Log4Func(("Mappping HC APIC-access page at %#RGp\n", GCPhysApicBase));
 
-    /* Unalias any existing mapping. */
+    /* Unalias the existing mapping. */
     int rc = PGMHandlerPhysicalReset(pVM, GCPhysApicBase);
     AssertRCReturn(rc, rc);
@@ -11398 +11398 @@
      * Virtualize memory-mapped accesses to the physical APIC (may take locks).
      */
+    /** @todo Doing this from ring-3 after VM setup phase causes a
+     *        VERR_IOM_MMIO_RANGE_NOT_FOUND guru while booting Visa 64 SMP VM. No
+     *        idea why atm. */
     PVM pVM = pVCpu->CTX_SUFF(pVM);
     if (   !pVCpu->hm.s.vmx.u64GstMsrApicBase
@@ -15502 +15505 @@
 
     /* See Intel spec. 27-6 "Exit Qualifications for APIC-access VM-exits from Linear Accesses & Guest-Phyiscal Addresses" */
-    uint32_t uAccessType = VMX_EXIT_QUAL_APIC_ACCESS_TYPE(pVmxTransient->uExitQual);
+    uint32_t const uAccessType = VMX_EXIT_QUAL_APIC_ACCESS_TYPE(pVmxTransient->uExitQual);
     VBOXSTRICTRC rcStrict2;
     switch (uAccessType)
@@ -15516 +15519 @@
             GCPhys &= PAGE_BASE_GC_MASK;
             GCPhys += VMX_EXIT_QUAL_APIC_ACCESS_OFFSET(pVmxTransient->uExitQual);
-            PVM pVM = pVCpu->CTX_SUFF(pVM);
             Log4Func(("Linear access uAccessType=%#x GCPhys=%#RGp Off=%#x\n", uAccessType, GCPhys,
                  VMX_EXIT_QUAL_APIC_ACCESS_OFFSET(pVmxTransient->uExitQual)));
 
+            PVM      pVM  = pVCpu->CTX_SUFF(pVM);
             PCPUMCTX pCtx = &pVCpu->cpum.GstCtx;
             rcStrict2 = IOMMMIOPhysHandler(pVM, pVCpu,
@@ -15537 +15540 @@
 
         default:
+        {
             Log4Func(("uAccessType=%#x\n", uAccessType));
             rcStrict2 = VINF_EM_RAW_EMULATE_INSTR;
             break;
+        }
     }