Changeset 79445 in vbox

Timestamp:

Jul 1, 2019 3:44:12 PM (6 years ago)

Author:

vboxsync

Message:

ValKit/reporter.py: Adjusted error count log prefix (iDebug > 1) and once again tried to make traceback more useful when logging exceptions. bugref:9151

File:

• trunk/src/VBox/ValidationKit/testdriver/reporter.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testdriver/reporter.py

@@ -499 +499 @@
         if iLevel <= self.iVerbose:
             # format it.
-            if self.iDebug > 0:
+            if self.iDebug <= 0:
+                sLogText = '%s %s' % (sTsPrf, sText);
+            elif self.iDebug <= 1:
                 sLogText = '%s %30s: %s' % (sTsPrf, sCaller, sText);
             else:
-                sLogText = '%s %s' % (sTsPrf, sText);
-            if self.iDebug > 1:
-                sLogText = 'err=%u %s' % (self.cErrors, sLogText,);
+                sLogText = '%s e=%u %30s: %s' % (sTsPrf, self.cErrors, sCaller, sText);
 
             # output it.
@@ -915 +915 @@
     def log(self, iLevel, sText, sCaller, sTsPrf):
         if iLevel <= self.iVerbose:
-            if self.iDebug > 0:
+            if self.iDebug <= 0:
+                sLogText = '%s %s' % (sTsPrf, sText);
+            elif self.iDebug <= 1:
                 sLogText = '%s %30s: %s' % (sTsPrf, sCaller, sText);
             else:
-                sLogText = '%s %s: %s' % (sTsPrf, self.sName, sText);
+                sLogText = '%s e=%u %30s: %s' % (sTsPrf, self.cErrors, sCaller, sText);
             self._writeOutput(sLogText);
         return 0;
@@ -1148 +1150 @@
                 try:
                     asInfo = formatExceptionOnly(oType, oValue, sCaller, sTsPrf);
+                    atEntries = traceback.extract_tb(oTraceback);
+                    atEntries.reverse();
                     if cFrames is not None and cFrames <= 1:
-                        asInfo = asInfo + traceback.format_tb(oTraceback, 1);
+                        if atEntries:
+                            asInfo = asInfo + traceback.format_list(atEntries[:1]);
                     else:
-                        asInfo.append('Traceback:')
-                        asInfo = asInfo + traceback.format_tb(oTraceback, cFrames);
+                        asInfo.append('Traceback (stack order):')
+                        if cFrames is not None and cFrames < len(atEntries):
+                            asInfo = asInfo + traceback.format_list(atEntries[:cFrames]);
+                        else:
+                            asInfo = asInfo + traceback.format_list(atEntries);
                         asInfo.append('Stack:')
                         asInfo = asInfo + traceback.format_stack(oTraceback.tb_frame.f_back, cFrames);