Changeset 79574 in vbox for trunk/src

Timestamp:

Jul 7, 2019 11:32:06 AM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9495: New Cloud VM wizard: A bit of refactoring for cloud creation procedure.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newcloudvm

Files:

• UIWizardNewCloudVM.cpp (modified) (1 diff)
• UIWizardNewCloudVM.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newcloudvm/UIWizardNewCloudVM.cpp

@@ -67 +67 @@
 bool UIWizardNewCloudVM::createCloudVM()
 {
-    /* Acquire prepared client and description: */
-    CCloudClient comCloudClient = field("client").value<CCloudClient>();
-    CVirtualSystemDescription comDescription = field("vsd").value<CVirtualSystemDescription>();
-    AssertReturn(comCloudClient.isNotNull() && comDescription.isNotNull(), false);
+    /* Prepare result: */
+    bool fResult = false;
 
-    /* Initiate cloud VM creation porocedure: */
-    CProgress comProgress = comCloudClient.LaunchVM(comDescription);
+    /* Main API request sequence, can be interrupted after any step: */
+    do
+    {
+        /* Acquire prepared client and description: */
+        CCloudClient comClient = field("client").value<CCloudClient>();
+        CVirtualSystemDescription comDescription = field("vsd").value<CVirtualSystemDescription>();
+        AssertReturn(comClient.isNotNull() && comDescription.isNotNull(), false);
 
-    /* Show error message if necessary: */
-    if (!comCloudClient.isOk())
-        msgCenter().cannotCreateCloudMachine(comCloudClient, this);
-    else
-    {
+        /* Initiate cloud VM creation procedure: */
+        CProgress comProgress = comClient.LaunchVM(comDescription);
+        if (!comClient.isOk())
+        {
+            msgCenter().cannotCreateCloudMachine(comClient, this);
+            break;
+        }
+
         /* Show "Create Cloud Machine" progress: */
-        msgCenter().showModalProgressDialog(comProgress, tr("Create Cloud Machine ..."), ":/progress_new_cloud_vm_90px.png", this, 0);
-        if (!comProgress.GetCanceled())
+        msgCenter().showModalProgressDialog(comProgress, tr("Create Cloud Machine ..."),
+                                            ":/progress_new_cloud_vm_90px.png", this, 0);
+        if (comProgress.GetCanceled())
+            break;
+        if (!comProgress.isOk() || comProgress.GetResultCode() != 0)
         {
-            /* Show error message if necessary: */
-            if (!comProgress.isOk() || comProgress.GetResultCode() != 0)
-                msgCenter().cannotCreateCloudMachine(comProgress, this);
-            else
-                return true;
+            msgCenter().cannotCreateCloudMachine(comProgress, this);
+            break;
         }
+
+        /* Finally, success: */
+        fResult = true;
     }
+    while (0);
 
-    /* Failure by default: */
-    return false;
+    /* Return result: */
+    return fResult;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newcloudvm/UIWizardNewCloudVM.h

@@ -51 +51 @@
     virtual void prepare() /* override */;
 
-    /** Create cloud VM. */
+    /** Create New Cloud VM. */
     bool createCloudVM();