Changeset 79671 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Jul 10, 2019 1:01:47 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131984

Message:

Devices/AHCI: Allow 16bit writes to a 32bit register by reading the missing bits instead of causing a guru meditation. This is undefined behavior as stated by the AHCI spec and some registers might return wrong results when accessed this way

File:

• trunk/src/VBox/Devices/Storage/DevAHCI.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -2463 +2463 @@
      * handling 2nd DWORD failures on split accesses correctly. */
     int rc = PDMDevHlpMMIORegister(pDevIns, GCPhysAddress, cb, NULL /*pvUser*/,
-                                   IOMMMIO_FLAGS_READ_DWORD | IOMMMIO_FLAGS_WRITE_ONLY_DWORD_QWORD,
+                                   IOMMMIO_FLAGS_READ_DWORD | IOMMMIO_FLAGS_WRITE_DWORD_QWORD_READ_MISSING,
                                    ahciMMIOWrite, ahciMMIORead, "AHCI");
     if (RT_FAILURE(rc))