Changeset 79698 in vbox for trunk/src/VBox/VMM

Timestamp:

Jul 11, 2019 1:54:20 PM (6 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Nested VMX: bugref:9180 comments.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -10633 +10633 @@
      *
      *   - We would need to perform VMREADs with interrupts disabled and is orders of
-     *     magnitude worse with nested virtualization.
+     *     magnitude worse when we run as a guest hypervisor without VMCS shadowing
+     *     supported by the host hypervisor.
      *
      *   - It affects the common VM-exit scenario and keeps interrupts disabled for a
-     *     longer period of time just for handling an edge case like host NMIs.
+     *     longer period of time just for handling an edge case like host NMIs which do
+     *     not occur nearly as frequently as other VM-exits.
      *
      * Let's cover the most likely scenario first. Check if we are on the target CPU
@@ -10820 +10822 @@
      *
      * If the outer guest is not intercepting #PFs, we can use the nested-guest #PF filters.
-     * If the outer guest is intercepting #PFs we must intercept all #PFs.
+     * If the outer guest is intercepting #PFs, we must intercept all #PFs.
      */
     uint32_t u32XcptPFMask;