Changeset 79762 in vbox for trunk/src/VBox

Timestamp:

Jul 14, 2019 3:51:10 AM (5 years ago)

Author:

vboxsync

Message:

Main/DHCPServer,Dhcpd,VBoxManage: Added --log option to the DHCP server so we can start logging early. Added log rotation and limits. Put the config file next to the log and leases file. Validate DHCP options by reusing the parser code from the server, adding a bunch more DHCP options to the parser. Removed legacy and hardcoded configuration options from the dhcp server, it's all config file now. Fixed a bug in the option parsing of the VBoxManage dhcpserver add/modify commands. [build fix] bugref:9288

File:

• trunk/src/VBox/NetworkServices/Dhcpd/DhcpOptions.cpp (modified) (3 diffs)

trunk/src/VBox/NetworkServices/Dhcpd/DhcpOptions.cpp

@@ -72 +72 @@
     }
 
-    dst[cbOrig+1] = cbValue;
+    dst[cbOrig+1] = (uint8_t)cbValue;
     return VINF_SUCCESS;
 }
@@ -182 +182 @@
 
 template <typename a_Type>
-static int DhcpOption::parseList(std::vector<a_Type> &aList, const char *pcszValue)
+/*static*/ int DhcpOption::parseList(std::vector<a_Type> &aList, const char *pcszValue)
 {
     std::vector<a_Type> vecTmp;
@@ -231 +231 @@
 /** ASSUME that uint8_t means hex byte strings. */
 template <>
-static int DhcpOption::parseList(std::vector<uint8_t> &aList, const char *pcszValue)
+/*static*/ int DhcpOption::parseList(std::vector<uint8_t> &aList, const char *pcszValue)
 {
     uint8_t     abBuf[256];