Changeset 79793 in vbox for trunk

Timestamp:

Jul 15, 2019 1:25:42 PM (6 years ago)

Author:

vboxsync

Message:

Main/Medium: Fix for setting create-only medium properties when querying info. Related to bugref:5899.

File:

• trunk/src/VBox/Main/src-server/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -8034 +8034 @@
 
 DECLCALLBACK(int) Medium::i_vdConfigUpdate(void *pvUser,
-                                                bool fCreate,
-                                                const char *pszName,
-                                                const char *pszValue)
-{
+                                           bool fCreate,
+                                           const char *pszName,
+                                           const char *pszValue)
+{
+    Medium *that = (Medium *)pvUser;
+
+    // Detect if this runs inside i_queryInfo() on the current thread.
+    // Skip if not. Check does not need synchronization.
+    if (!that->m || !that->m->queryInfoRunning || !that->m->queryInfoSem.isWriteLockOnCurrentThread())
+        return VINF_SUCCESS;
+
+    // It's guaranteed that this code is executing inside Medium::i_queryInfo,
+    // can assume it took care of synchronization.
     int rv = VINF_SUCCESS;
-    Utf8Str pName = Utf8Str(pszName);
-    Medium *that = (Medium *)pvUser;
-    AutoWriteLock mlock(that COMMA_LOCKVAL_SRC_POS);
-    settings::StringsMap::const_iterator it = that->m->mapProperties.find(pName);
+    Utf8Str strName(pszName);
+    settings::StringsMap::const_iterator it = that->m->mapProperties.find(strName);
     if (it == that->m->mapProperties.end() && !fCreate)
         rv = VERR_CFGM_VALUE_NOT_FOUND;
     else
-        that->m->mapProperties[pName] = Utf8Str(pszValue);
-    mlock.release();
+        that->m->mapProperties[strName] = Utf8Str(pszValue);
     return rv;
 }