Changeset 7981 in vbox for trunk/src/VBox/Devices

Timestamp:

Apr 15, 2008 12:24:52 PM (17 years ago)

Author:

vboxsync

Message:

VMDK: added missing bit for optimizing away writes with the same data (takes care of zero block writes and same data writes for snapshots in one go).

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -3728 +3728 @@
     }
 
-    /** @todo implement suppressing of zero data writes (a bit tricky in this
-     * case, as VMDK has no marker for zero blocks). We somehow need to get the
-     * information whether the information in this area is all zeroes as of the
-     * parent image. Then (based on the assumption that parent images are
-     * immutable) the write can be ignored. */
-
     /* Handle the write according to the current extent type. */
     switch (pExtent->enmType)
@@ -3752 +3746 @@
                 {
                     /* Full block write to a previously unallocated block.
-                     * Allocate GT and find out where to store the grain. */
-                    rc = vmdkAllocGrain(pImage->pGTCache, pExtent,
-                                        uSectorExtentRel, pvBuf, cbToWrite);
+                     * Check if the caller wants to avoid this. */
+                    if (!(fWrite & VD_WRITE_NO_ALLOC))
+                    {
+                        /* Allocate GT and find out where to store the grain. */
+                        rc = vmdkAllocGrain(pImage->pGTCache, pExtent,
+                                            uSectorExtentRel, pvBuf, cbToWrite);
+                    }
+                    else
+                        rc = VERR_VDI_BLOCK_FREE;
                     *pcbPreRead = 0;
                     *pcbPostRead = 0;