Changeset 79823 in vbox for trunk/src/VBox/Main/src-server/DHCPServerImpl.cpp

Timestamp:

Jul 16, 2019 8:14:56 PM (5 years ago)

Author:

vboxsync

Message:

Main/DHCPServer: It's okay to put the DHCP server IP in the dynamic range now, it's treated like a fixed allocation. bugref:9288

File:

• trunk/src/VBox/Main/src-server/DHCPServerImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/DHCPServerImpl.cpp

@@ -551 +551 @@
         return setError(E_INVALIDARG, tr("Invalid range upper address"), aUpperIP.c_str(), aNetworkMask.c_str());
 
-    /* The range should be valid ... */
+    /* The range should be valid. (It's okay to overlap the server IP.) */
     if (LowerIP.u > UpperIP.u)
         return setError(E_INVALIDARG, tr("Lower bound must be less or eqaul than the upper: %s vs %s"),
                         aLowerIP.c_str(), aUpperIP.c_str());
-
-    /* ... and shouldn't contain the server's address */
-    if (LowerIP.u <= IPAddress.u && IPAddress.u <= UpperIP.u)
-        return setError(E_INVALIDARG, tr("Server address within range bounds: %s in %s - %s"),
-                        aIPAddress.c_str(), aLowerIP.c_str(), aUpperIP.c_str());
 
     /*