Changeset 79825 in vbox for trunk/src/VBox

Timestamp:

Jul 16, 2019 10:01:01 PM (5 years ago)

Author:

vboxsync

Message:

Dhcpd: Removed some old test code. bugref:9288

Location:

trunk/src/VBox/NetworkServices/Dhcpd

Files:

• Config.cpp (modified) (1 diff)
• DHCPD.cpp (modified) (1 diff)

trunk/src/VBox/NetworkServices/Dhcpd/Config.cpp

@@ -1158 +1158 @@
     }
 
-
-#if 0 /* bird disabled this as it looks dubious and testing only. */
-    /** @todo XXX: testing ... */
-    if (vmopts != NULL)
-    {
-        for (optmap_t::const_iterator it = vmopts->begin(); it != vmopts->end(); ++it)
-        {
-            std::shared_ptr<DhcpOption> opt(it->second);
-            if (a_rRetOpts.count(opt->optcode()) == 0 && opt->optcode() > 127)
-            {
-                a_rRetOpts << opt;
-                LogRel2(("... forcing VM option %d (%#x)\n", opt->optcode(), opt->optcode()));
-            }
-        }
-    }
-
-    for (optmap_t::const_iterator it = m_GlobalOptions.begin(); it != m_GlobalOptions.end(); ++it)
-    {
-        std::shared_ptr<DhcpOption> opt(it->second);
-        if (a_rRetOpts.count(opt->optcode()) == 0 && opt->optcode() > 127)
-        {
-            a_rRetOpts << opt;
-            LogRel2(("... forcing global option %d (%#x)", opt->optcode(), opt->optcode()));
-        }
-    }
-#endif
-
     return a_rRetOpts;
 }

trunk/src/VBox/NetworkServices/Dhcpd/DHCPD.cpp

@@ -332 +332 @@
     ack->addOptions(m_pConfig->getOptionsForClient(replyOptions, optlist, vecConfigs));
 
-    /** @todo r=bird: Sec 9.9 in rfc-2132 indicates the server only sends this in NACKs. Test code? */
-    ack->addOption(OptMessage("Ok, ok, here it is"));
-
     ack->maybeUnicast(req);
     return ack.release();