Changeset 79855 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jul 18, 2019 9:56:56 AM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9241: VirtualBox Manager: Details pane: A bit of cleanup for UIDetailsView.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/details

Files:

• UIDetailsView.cpp (modified) (3 diffs)
• UIDetailsView.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsView.cpp

@@ -18 +18 @@
 /* Qt includes: */
 #include <QAccessibleWidget>
-#include <QApplication>
 #include <QScrollBar>
 
@@ -111 +110 @@
     , m_iMinimumWidthHint(0)
 {
-    /* Install Details-view accessibility interface factory: */
-    QAccessible::installFactory(UIAccessibilityInterfaceForUIDetailsView::pFactory);
-
-    /* Setup frame: */
-    setFrameShape(QFrame::NoFrame);
-    setFrameShadow(QFrame::Plain);
-    setAlignment(Qt::AlignLeft | Qt::AlignTop);
-
-    /* Setup scroll-bars policy: */
-    setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
-    setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
-
-    /* Update scene-rect: */
-    updateSceneRect();
-
-    /* Translate finally: */
-    retranslateUi();
+    prepare();
 }
 
-void UIDetailsView::sltMinimumWidthHintChanged(int iMinimumWidthHint)
+void UIDetailsView::sltMinimumWidthHintChanged(int iHint)
 {
     /* Is there something changed? */
-    if (m_iMinimumWidthHint == iMinimumWidthHint)
+    if (m_iMinimumWidthHint == iHint)
         return;
 
     /* Remember new value: */
-    m_iMinimumWidthHint = iMinimumWidthHint;
+    m_iMinimumWidthHint = iHint;
     if (m_iMinimumWidthHint <= 0)
         m_iMinimumWidthHint = 1;
 
     /* Set minimum view width according passed width-hint: */
-    setMinimumWidth(2 * frameWidth() + iMinimumWidthHint + verticalScrollBar()->sizeHint().width());
+    setMinimumWidth(2 * frameWidth() + m_iMinimumWidthHint + verticalScrollBar()->sizeHint().width());
 
     /* Update scene-rect: */
@@ -167 +150 @@
 }
 
+void UIDetailsView::prepare()
+{
+    /* Install Details-view accessibility interface factory: */
+    QAccessible::installFactory(UIAccessibilityInterfaceForUIDetailsView::pFactory);
+
+    /* Setup frame: */
+    setFrameShape(QFrame::NoFrame);
+    setFrameShadow(QFrame::Plain);
+    setAlignment(Qt::AlignLeft | Qt::AlignTop);
+
+    /* Setup scroll-bars policy: */
+    setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+    setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+
+    /* Update scene-rect: */
+    updateSceneRect();
+
+    /* Translate finally: */
+    retranslateUi();
+}
+
 void UIDetailsView::updateSceneRect()
 {
     setSceneRect(0, 0, m_iMinimumWidthHint, height());
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsView.h

@@ -36 +36 @@
 signals:
 
-    /* Notifier: Resize stuff: */
+    /** Notifies listeners about resize. */
     void sigResized();
 
@@ -50 +50 @@
 public slots:
 
-    /* Handlers: Size-hint stuff: */
-    void sltMinimumWidthHintChanged(int iMinimumWidthHint);
+    /** Handles minimum width @a iHint change. */
+    void sltMinimumWidthHintChanged(int iHint);
 
-private:
+protected:
 
     /** Handles translation event. */
     virtual void retranslateUi() /* override */;
 
-    /* Handler: Resize-event stuff: */
-    void resizeEvent(QResizeEvent *pEvent);
+    /** Handles resize @a pEvent. */
+    virtual void resizeEvent(QResizeEvent *pEvent) /* override */;
 
-    /* Helper: Update stuff: */
+private:
+
+    /** Prepares all. */
+    void prepare();
+
+    /** Updates scene rectangle. */
     void updateSceneRect();
 
@@ -67 +72 @@
     UIDetails *m_pDetails;
 
-    /* Variables: */
+    /** Updates scene rectangle. */
     int m_iMinimumWidthHint;
 };
 
 #endif /* !FEQT_INCLUDED_SRC_manager_details_UIDetailsView_h */
-