Changeset 80046 in vbox

Timestamp:

Jul 29, 2019 4:06:19 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:7720: VirtualBox Manager: Details pane: Possibility to edit VM video memory size on-the-fly.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIDetailsGenerator.cpp (modified) (1 diff)
• globals/UIMachineAttributeSetter.cpp (modified) (1 diff)
• globals/UIMachineAttributeSetter.h (modified) (1 diff)
• manager/details/UIDetailsElement.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp

@@ -256 +256 @@
     /* Video memory: */
     if (fOptions & UIExtraDataMetaDefs::DetailsElementOptionTypeDisplay_VRAM)
+    {
+        /* Configure hovering anchor: */
+        const QString strAnchorType = QString("video_memory");
+        const int iVideoMemory = comMachine.GetVRAMSize();
         table << UITextTableLine(QApplication::translate("UIDetails", "Video Memory", "details (display)"),
-                                 QApplication::translate("UIDetails", "%1 MB", "details").arg(comMachine.GetVRAMSize()));
+                                 QApplication::translate("UIDetails", "<a href=#%1,%2>%2 MB</a>", "details")
+                                    .arg(strAnchorType).arg(iVideoMemory));
+    }
 
     /* Screens: */

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMachineAttributeSetter.cpp

@@ -111 +111 @@
                 break;
             }
+            case MachineAttribute_VideoMemory:
+            {
+                /* Change machine video memory (VRAM): */
+                comMachine.SetVRAMSize(guiAttribute.toInt());
+                if (!comMachine.isOk())
+                {
+                    msgCenter().cannotChangeMachineAttribute(comMachine);
+                    fErrorHappened = true;
+                }
+                break;
+            }
             default:
                 break;

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMachineAttributeSetter.h

@@ -35 +35 @@
     MachineAttribute_BaseMemory,
     MachineAttribute_BootOrder,
+    MachineAttribute_VideoMemory,
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsElement.cpp

@@ -40 +40 @@
 #include "UIMachineAttributeSetter.h"
 #include "UINameAndSystemEditor.h"
+#include "UIVideoMemoryEditor.h"
 #include "UIVirtualBoxManager.h"
 
@@ -52 +53 @@
     AnchorRole_BaseMemory,
     AnchorRole_BootOrder,
+    AnchorRole_VideoMemory,
     AnchorRole_Storage,
 };
@@ -156 +158 @@
     m_pTextPane->setAnchorRoleRestricted("#base_memory", cal != ConfigurationAccessLevel_Full);
     m_pTextPane->setAnchorRoleRestricted("#boot_order", cal != ConfigurationAccessLevel_Full);
+    m_pTextPane->setAnchorRoleRestricted("#video_memory", cal != ConfigurationAccessLevel_Full);
     m_pTextPane->setAnchorRoleRestricted("#mount", cal == ConfigurationAccessLevel_Null);
     m_pTextPane->setAnchorRoleRestricted("#attach", cal != ConfigurationAccessLevel_Full);
@@ -440 +443 @@
     roles["#base_memory"] = AnchorRole_BaseMemory;
     roles["#boot_order"] = AnchorRole_BootOrder;
+    roles["#video_memory"] = AnchorRole_VideoMemory;
     roles["#mount"] = AnchorRole_Storage;
     roles["#attach"] = AnchorRole_Storage;
@@ -571 +575 @@
             break;
         }
+        case AnchorRole_VideoMemory:
+        {
+            /* Prepare popup: */
+            QPointer<QIDialogContainer> pPopup = new QIDialogContainer(0, Qt::Tool);
+            if (pPopup)
+            {
+                /* Prepare editor: */
+                UIVideoMemoryEditor *pEditor = new UIVideoMemoryEditor(pPopup, true /* with label */);
+                if (pEditor)
+                {
+                    pEditor->setValue(strData.section(',', 0, 0).toInt());
+                    connect(pEditor, &UIVideoMemoryEditor::sigValidChanged,
+                            pPopup.data(), &QIDialogContainer::setOkButtonEnabled);
+                    pPopup->setWidget(pEditor);
+                }
+
+                /* Adjust popup geometry: */
+                pPopup->move(QCursor::pos());
+                pPopup->adjustSize();
+
+                // WORKAROUND:
+                // On Windows, Tool dialogs aren't activated by default by some reason.
+                // So we have created sltActivateWindow wrapping actual activateWindow
+                // to fix that annoying issue.
+                QMetaObject::invokeMethod(pPopup, "sltActivateWindow", Qt::QueuedConnection);
+                /* Execute popup, change machine name if confirmed: */
+                if (pPopup->exec() == QDialog::Accepted)
+                    setMachineAttribute(machine(), MachineAttribute_VideoMemory, QVariant::fromValue(pEditor->value()));
+
+                /* Delete popup: */
+                delete pPopup;
+            }
+            break;
+        }
         case AnchorRole_Storage:
         {