Changeset 80073 in vbox

Timestamp:

Jul 31, 2019 11:54:13 AM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:7720: VirtualBox Manager: Details pane: Possibility to edit VM graphics controller type on-the-fly.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIDetailsGenerator.cpp (modified) (1 diff)
• globals/UIMachineAttributeSetter.cpp (modified) (1 diff)
• globals/UIMachineAttributeSetter.h (modified) (1 diff)
• manager/details/UIDetailsElement.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp

@@ -294 +294 @@
     /* Graphics Controller: */
     if (fOptions & UIExtraDataMetaDefs::DetailsElementOptionTypeDisplay_GraphicsController)
+    {
+        const QString strAnchorType = QString("graphics_controller_type");
+        const KGraphicsControllerType enmType = comMachine.GetGraphicsControllerType();
         table << UITextTableLine(QApplication::translate("UIDetails", "Graphics Controller", "details (display)"),
-                                 gpConverter->toString(comMachine.GetGraphicsControllerType()));
+                                 QApplication::translate("UIDetails", "<a href=#%1,%2>%3</a>", "details")
+                                     .arg(strAnchorType)
+                                     .arg((int)enmType)
+                                     .arg(gpConverter->toString(enmType)));
+    }
 
     /* Acceleration: */

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMachineAttributeSetter.cpp

@@ -122 +122 @@
                 break;
             }
+            case MachineAttribute_GraphicsControllerType:
+            {
+                /* Change machine graphics controller type: */
+                comMachine.SetGraphicsControllerType(guiAttribute.value<KGraphicsControllerType>());
+                if (!comMachine.isOk())
+                {
+                    msgCenter().cannotChangeMachineAttribute(comMachine);
+                    fErrorHappened = true;
+                }
+                break;
+            }
             default:
                 break;

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMachineAttributeSetter.h

@@ -36 +36 @@
     MachineAttribute_BootOrder,
     MachineAttribute_VideoMemory,
+    MachineAttribute_GraphicsControllerType,
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsElement.cpp

@@ -35 +35 @@
 #include "UIDetailsModel.h"
 #include "UIExtraDataManager.h"
+#include "UIGraphicsControllerEditor.h"
 #include "UIGraphicsRotatorButton.h"
 #include "UIGraphicsTextPane.h"
@@ -54 +55 @@
     AnchorRole_BootOrder,
     AnchorRole_VideoMemory,
+    AnchorRole_GraphicsControllerType,
     AnchorRole_Storage,
 };
@@ -159 +161 @@
     m_pTextPane->setAnchorRoleRestricted("#boot_order", cal != ConfigurationAccessLevel_Full);
     m_pTextPane->setAnchorRoleRestricted("#video_memory", cal != ConfigurationAccessLevel_Full);
+    m_pTextPane->setAnchorRoleRestricted("#graphics_controller_type", cal != ConfigurationAccessLevel_Full);
     m_pTextPane->setAnchorRoleRestricted("#mount", cal == ConfigurationAccessLevel_Null);
     m_pTextPane->setAnchorRoleRestricted("#attach", cal != ConfigurationAccessLevel_Full);
@@ -444 +447 @@
     roles["#boot_order"] = AnchorRole_BootOrder;
     roles["#video_memory"] = AnchorRole_VideoMemory;
+    roles["#graphics_controller_type"] = AnchorRole_GraphicsControllerType;
     roles["#mount"] = AnchorRole_Storage;
     roles["#attach"] = AnchorRole_Storage;
@@ -609 +613 @@
             break;
         }
+        case AnchorRole_GraphicsControllerType:
+        {
+            /* Prepare popup: */
+            QPointer<QIDialogContainer> pPopup = new QIDialogContainer(0, Qt::Tool);
+            if (pPopup)
+            {
+                /* Prepare editor: */
+                UIGraphicsControllerEditor *pEditor = new UIGraphicsControllerEditor(pPopup, true /* with label */);
+                if (pEditor)
+                {
+                    pEditor->setValue(static_cast<KGraphicsControllerType>(strData.section(',', 0, 0).toInt()));
+                    pPopup->setWidget(pEditor);
+                }
+
+                /* Adjust popup geometry: */
+                pPopup->move(QCursor::pos());
+                pPopup->adjustSize();
+
+                // WORKAROUND:
+                // On Windows, Tool dialogs aren't activated by default by some reason.
+                // So we have created sltActivateWindow wrapping actual activateWindow
+                // to fix that annoying issue.
+                QMetaObject::invokeMethod(pPopup, "sltActivateWindow", Qt::QueuedConnection);
+                /* Execute popup, change machine name if confirmed: */
+                if (pPopup->exec() == QDialog::Accepted)
+                    setMachineAttribute(machine(), MachineAttribute_GraphicsControllerType, QVariant::fromValue(pEditor->value()));
+
+                /* Delete popup: */
+                delete pPopup;
+            }
+            break;
+        }
         case AnchorRole_Storage:
         {