Changeset 80481 in vbox for trunk/src/VBox

Timestamp:

Aug 28, 2019 2:58:11 PM (5 years ago)

Author:

vboxsync

Message:

IPRT/process-win.cpp: Adding RTPROC_FLAGS_AS_IMPERSONATED_TOKEN and RTPROC_FLAGS_NO_WAIT for windows. bugref:9341 bugref:8078

File:

• trunk/src/VBox/Runtime/r3/win/process-win.cpp (modified) (18 diffs)

trunk/src/VBox/Runtime/r3/win/process-win.cpp

@@ -418 +418 @@
 
 /**
+ * The following NT call is for v3.51 and does the equivalent of:
+ *      DuplicateTokenEx(hSrcToken, MAXIMUM_ALLOWED, NULL,
+ *                       SecurityIdentification, TokenPrimary, phToken);
+ */
+static int rtProcWinDuplicateToken(HANDLE hSrcToken, PHANDLE phToken)
+{
+    int rc;
+    if (g_pfnNtDuplicateToken)
+    {
+        SECURITY_QUALITY_OF_SERVICE SecQoS;
+        SecQoS.Length              = sizeof(SecQoS);
+        SecQoS.ImpersonationLevel  = SecurityIdentification;
+        SecQoS.ContextTrackingMode = SECURITY_DYNAMIC_TRACKING;
+        SecQoS.EffectiveOnly       = FALSE;
+
+        OBJECT_ATTRIBUTES ObjAttr;
+        InitializeObjectAttributes(&ObjAttr, NULL /*Name*/, 0 /*OBJ_XXX*/, NULL /*Root*/, NULL /*SecDesc*/);
+        ObjAttr.SecurityQualityOfService = &SecQoS;
+
+        NTSTATUS rcNt = g_pfnNtDuplicateToken(hSrcToken, MAXIMUM_ALLOWED, &ObjAttr, FALSE, TokenPrimary, phToken);
+        if (NT_SUCCESS(rcNt))
+            rc = VINF_SUCCESS;
+        else
+            rc = RTErrConvertFromNtStatus(rcNt);
+    }
+    else
+        rc = VERR_SYMBOL_NOT_FOUND; /** @todo do we really need to duplicate the token? */
+    return rc;
+}
+
+
+/**
+ * Get the token assigned to specified thread indicated by @a hThread.
+ * 
+ * Only used when RTPROC_FLAGS_AS_IMPERSONATED_TOKEN is in effect and the
+ * purpose is to get a duplicate the impersonated token of the current thread.
+ *
+ * @returns IPRT status code.
+ * @param   hThread         The thread handle (current thread).
+ * @param   phToken         Where to return the a duplicate of the thread token
+ *                          handle on success. (The caller closes it.)
+ */
+static int rtProcWinGetThreadTokenHandle(HANDLE hThread, PHANDLE phToken)
+{
+    AssertPtr(phToken);
+
+    int     rc;
+    HANDLE hTokenThread;
+    if (OpenThreadToken(hThread,
+                        TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY | TOKEN_DUPLICATE
+                        | TOKEN_ASSIGN_PRIMARY | TOKEN_ADJUST_SESSIONID | TOKEN_READ | TOKEN_WRITE,
+                        TRUE /* OpenAsSelf - for impersonation at SecurityIdentification level */,
+                        &hTokenThread))
+    {
+        rc = rtProcWinDuplicateToken(hTokenThread, phToken);
+        CloseHandle(hTokenThread);
+    }
+    else
+        rc = RTErrConvertFromWin32(GetLastError());
+    return rc;
+}
+
+
+/**
  * Get the process token of the process indicated by @a dwPID if the @a pSid
  * matches.
@@ -459 +523 @@
                         {
                             /*
-                             * The following NT call is for v3.51 and does the equivalent of:
-                             *      DuplicateTokenEx(hTokenProc, MAXIMUM_ALLOWED, NULL,
-                             *                       SecurityIdentification, TokenPrimary, phToken);
+                             * So we found the process instance which belongs to the user we want to
+                             * to run our new process under. This duplicated token will be used for
+                             * the actual CreateProcessAsUserW() call then.
                              */
-                            if (g_pfnNtDuplicateToken)
-                            {
-                                SECURITY_QUALITY_OF_SERVICE SecQoS;
-                                SecQoS.Length              = sizeof(SecQoS);
-                                SecQoS.ImpersonationLevel  = SecurityIdentification;
-                                SecQoS.ContextTrackingMode = SECURITY_DYNAMIC_TRACKING;
-                                SecQoS.EffectiveOnly       = FALSE;
-
-                                OBJECT_ATTRIBUTES ObjAttr;
-                                InitializeObjectAttributes(&ObjAttr, NULL /*Name*/, 0 /*OBJ_XXX*/, NULL /*Root*/, NULL /*SecDesc*/);
-                                ObjAttr.SecurityQualityOfService = &SecQoS;
-
-                                NTSTATUS rcNt = g_pfnNtDuplicateToken(hTokenProc, MAXIMUM_ALLOWED, &ObjAttr, FALSE,
-                                                                      TokenPrimary, phToken);
-                                if (NT_SUCCESS(rcNt))
-                                {
-                                    /*
-                                     * So we found the process instance which belongs to the user we want to
-                                     * to run our new process under. This duplicated token will be used for
-                                     * the actual CreateProcessAsUserW() call then.
-                                     */
-                                    rc = VINF_SUCCESS;
-                                }
-                                else
-                                    rc = RTErrConvertFromNtStatus(rcNt);
-
-                            }
-                            else
-                                rc = VERR_SYMBOL_NOT_FOUND; /** @todo do we really need to duplicate the token? */
+                            rc = rtProcWinDuplicateToken(hTokenProc, phToken);
                         }
                         else
@@ -946 +982 @@
  * @returns Pointer to the SID on success. Free by calling RTMemFree.
  * @param   hToken              The token..
- */
-static PSID rtProcWinGetTokenUserSid(HANDLE hToken)
-{
+ * @param   prc                 Optional return code. 
+ */
+static PSID rtProcWinGetTokenUserSid(HANDLE hToken, int *prc)
+{
+    int rcIgn;
+    if (!prc)
+        prc = &rcIgn;
+    *prc = VERR_NO_MEMORY;
+
     /*
      * Get the groups associated with the token.  We just try a size first then
@@ -959 +1001 @@
     if (!GetTokenInformation(hToken, TokenUser, pUser, cbUser, &cbNeeded))
     {
+        DWORD dwErr = GetLastError();
         RTMemTmpFree(pUser);
-        AssertReturn(GetLastError() == ERROR_INSUFFICIENT_BUFFER, NULL);
+        AssertLogRelMsgReturnStmt(dwErr == ERROR_INSUFFICIENT_BUFFER,
+                                  ("rtProcWinGetTokenUserSid: GetTokenInformation failed with %u\n", dwErr),
+                                  *prc = RTErrConvertFromWin32(dwErr), NULL);
         cbUser = cbNeeded + 128;
         pUser = (PTOKEN_USER)RTMemTmpAlloc(cbUser);
@@ -966 +1011 @@
         if (!GetTokenInformation(hToken, TokenUser, pUser, cbUser, &cbNeeded))
         {
+            dwErr = GetLastError();
+            *prc = RTErrConvertFromWin32(dwErr);
             RTMemTmpFree(pUser);
-            AssertFailedReturn(NULL);
+            AssertLogRelMsgFailedReturn(("rtProcWinGetTokenUserSid: GetTokenInformation failed with %u\n", dwErr), NULL);
         }
     }
@@ -1331 +1378 @@
             {
                 /*PSID pSid = rtProcWinGetTokenLogonSid(hTokenToUse); - Better to use the user SID. Avoid overflowing the ACL. */
-                PSID pSid = rtProcWinGetTokenUserSid(hTokenToUse);
+                PSID pSid = rtProcWinGetTokenUserSid(hTokenToUse, NULL /*prc*/);
                 if (pSid)
                 {
@@ -1442 +1489 @@
 
 /**
+ * Tries to resolve the name of the SID.
+ *
+ * @returns IPRT status code.
+ * @param   pSid        The SID to resolve.
+ * @param   ppwszName   Where to return the name. Use RTUtf16Free to free.
+ */
+static int rtProcWinSidToName(PSID pSid, PRTUTF16 *ppwszName)
+{
+    *ppwszName = NULL;
+
+    /*
+     * Use large initial buffers here to try avoid having to repeat the call.
+     */
+    DWORD cwcAllocated = 512;
+    while (cwcAllocated < _32K)
+    {
+        PRTUTF16 pwszName = RTUtf16Alloc(cwcAllocated * sizeof(RTUTF16));
+        AssertReturn(pwszName, VERR_NO_UTF16_MEMORY);
+        PRTUTF16 pwszDomain = RTUtf16Alloc(cwcAllocated * sizeof(RTUTF16));
+        AssertReturnStmt(pwszDomain, RTUtf16Free(pwszName), VERR_NO_UTF16_MEMORY);
+
+        DWORD cwcName   = cwcAllocated;
+        DWORD cwcDomain = cwcAllocated;
+        SID_NAME_USE SidNameUse = SidTypeUser;
+        if (LookupAccountSidW(NULL /*lpSystemName*/, pSid, pwszName, &cwcName, pwszDomain, &cwcDomain, &SidNameUse))
+        {
+            *ppwszName = pwszName;
+            RTUtf16Free(pwszDomain); /* may need this later. */
+            return VINF_SUCCESS;
+        }
+
+        DWORD const dwErr = GetLastError();
+        RTUtf16Free(pwszName);
+        RTUtf16Free(pwszDomain);
+        if (dwErr != ERROR_INSUFFICIENT_BUFFER)
+            return RTErrConvertFromWin32(dwErr);
+        cwcAllocated = RT_MAX(cwcName, cwcDomain) + 1;
+    }
+
+    return RTErrConvertFromWin32(ERROR_INSUFFICIENT_BUFFER);
+}
+
+
+/**
+ * Tries to resolve the user name for the token.
+ *
+ * @returns IPRT status code.
+ * @param   hToken      The token.
+ * @param   ppwszUser   Where to return the username. Use RTUtf16Free to free.
+ */
+static int rtProcWinTokenToUsername(HANDLE hToken, PRTUTF16 *ppwszUser)
+{
+    int rc = VINF_SUCCESS;
+    PSID pSid = rtProcWinGetTokenUserSid(hToken, &rc);
+    if (pSid)
+    {
+        rc = rtProcWinSidToName(pSid, ppwszUser);
+        RTMemFree(pSid);
+    }
+    else
+        *ppwszUser = NULL;
+    return rc;
+}
+
+
+/**
  * Method \#2.
+ *
+ * @note pwszUser can be NULL when RTPROC_FLAGS_AS_IMPERSONATED_TOKEN is set.
  */
 static int rtProcWinCreateAsUser2(PRTUTF16 pwszUser, PRTUTF16 pwszPassword, PRTUTF16 *ppwszExec, PRTUTF16 pwszCmdLine,
@@ -1477 +1592 @@
     DWORD   dwErr       = NO_ERROR;
     HANDLE  hTokenLogon = INVALID_HANDLE_VALUE;
-    int rc = rtProcWinUserLogon(pwszUser, pwszPassword, &hTokenLogon);
+    int rc;
+    if (fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)
+        rc = rtProcWinGetThreadTokenHandle(GetCurrentThread(), &hTokenLogon);
+    else
+        rc = rtProcWinUserLogon(pwszUser, pwszPassword, &hTokenLogon);
     if (RT_SUCCESS(rc))
     {
-        DWORD  fRc;
+        BOOL   fRc;
         bool   fFound = false;
         HANDLE hTokenUserDesktop = INVALID_HANDLE_VALUE;
@@ -1492 +1611 @@
         if (fFlags & RTPROC_FLAGS_SERVICE)
         {
+            /*
+             * For the token search we need a SID.
+             */
             PSID pSid = NULL;
-
-            /* Try query the SID and domain sizes first. */
-            DWORD        cbSid      = 0; /* Must be zero to query size! */
-            DWORD        cwcDomain  = 0;
-            SID_NAME_USE SidNameUse = SidTypeUser;
-            fRc = LookupAccountNameW(NULL, pwszUser, NULL, &cbSid, NULL, &cwcDomain, &SidNameUse);
-            if (!fRc)
-            {
-                dwErr = GetLastError();
-
-                /*
-                 * The errors ERROR_TRUSTED_DOMAIN_FAILURE and ERROR_TRUSTED_RELATIONSHIP_FAILURE
-                 * can happen if an ADC (Active Domain Controller) is offline or not reachable.
-                 *
-                 * Try to handle these errors gracefully by asking the local LSA cache of the
-                 * client OS instead then. For this to work, the desired user must have at
-                 * least logged in once at that client -- otherwise there will be no cached
-                 * authentication available and this fallback will fail.
-                 */
-                if (   g_pfnLsaLookupNames2 /* >= Windows XP */
-                    && (   dwErr == ERROR_TRUSTED_DOMAIN_FAILURE
-                        || dwErr == ERROR_TRUSTED_RELATIONSHIP_FAILURE))
+            if (fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)
+                pSid = rtProcWinGetTokenUserSid(hTokenLogon, &rc);
+            else
+            {
+                /** @todo r=bird: why can't we do this in the same manner as in the
+                 *        RTPROC_FLAGS_AS_IMPERSONATED_TOKEN case above? */
+
+                /* Try query the SID and domain sizes first. */
+                DWORD        cbSid      = 0; /* Must be zero to query size! */
+                DWORD        cwcDomain  = 0;
+                SID_NAME_USE SidNameUse = SidTypeUser;
+                fRc = LookupAccountNameW(NULL, pwszUser, NULL, &cbSid, NULL, &cwcDomain, &SidNameUse);
+                if (!fRc)
                 {
-                    LSA_OBJECT_ATTRIBUTES objAttr;
-                    RT_ZERO(objAttr);
-                    objAttr.Length = sizeof(LSA_OBJECT_ATTRIBUTES);
-
-                    LSA_HANDLE lsahPolicy;
-                    NTSTATUS ntSts = LsaOpenPolicy(NULL, &objAttr, POLICY_LOOKUP_NAMES, &lsahPolicy);
-                    if (ntSts == STATUS_SUCCESS)
+                    dwErr = GetLastError();
+
+                    /*
+                     * The errors ERROR_TRUSTED_DOMAIN_FAILURE and ERROR_TRUSTED_RELATIONSHIP_FAILURE
+                     * can happen if an ADC (Active Domain Controller) is offline or not reachable.
+                     *
+                     * Try to handle these errors gracefully by asking the local LSA cache of the
+                     * client OS instead then. For this to work, the desired user must have at
+                     * least logged in once at that client -- otherwise there will be no cached
+                     * authentication available and this fallback will fail.
+                     */
+                    if (   g_pfnLsaLookupNames2 /* >= Windows XP */
+                        && (   dwErr == ERROR_TRUSTED_DOMAIN_FAILURE
+                            || dwErr == ERROR_TRUSTED_RELATIONSHIP_FAILURE))
                     {
-                        RTPROCWINACCOUNTINFO accountInfo;
-                        RT_ZERO(accountInfo);
-                        rc = rtProcWinParseAccountInfo(pwszUser, &accountInfo);
-                        AssertRC(rc);
-                        AssertPtr(accountInfo.pwszUserName);
-
-                        LSA_UNICODE_STRING lsaUser;
-                        lsaUser.Buffer        = accountInfo.pwszUserName;
-                        lsaUser.Length        = (USHORT)(RTUtf16Len(accountInfo.pwszUserName) * sizeof(WCHAR));
-                        lsaUser.MaximumLength = lsaUser.Length;
-
-                        PLSA_REFERENCED_DOMAIN_LIST pDomainList     = NULL;
-                        PLSA_TRANSLATED_SID2        pTranslatedSids = NULL;
-                        ntSts = g_pfnLsaLookupNames2(lsahPolicy, 0 /* Flags */,
-                                                     1 /* Number of users to lookup */,
-                                                     &lsaUser, &pDomainList, &pTranslatedSids);
+                        LSA_OBJECT_ATTRIBUTES objAttr;
+                        RT_ZERO(objAttr);
+                        objAttr.Length = sizeof(LSA_OBJECT_ATTRIBUTES);
+
+                        LSA_HANDLE lsahPolicy;
+                        NTSTATUS ntSts = LsaOpenPolicy(NULL, &objAttr, POLICY_LOOKUP_NAMES, &lsahPolicy);
                         if (ntSts == STATUS_SUCCESS)
                         {
-                            AssertPtr(pDomainList);
-                            AssertPtr(pTranslatedSids);
+                            RTPROCWINACCOUNTINFO accountInfo;
+                            RT_ZERO(accountInfo);
+                            rc = rtProcWinParseAccountInfo(pwszUser, &accountInfo);
+                            AssertRC(rc);
+                            AssertPtr(accountInfo.pwszUserName);
+
+                            LSA_UNICODE_STRING lsaUser;
+                            lsaUser.Buffer        = accountInfo.pwszUserName;
+                            lsaUser.Length        = (USHORT)(RTUtf16Len(accountInfo.pwszUserName) * sizeof(WCHAR));
+                            lsaUser.MaximumLength = lsaUser.Length;
+
+                            PLSA_REFERENCED_DOMAIN_LIST pDomainList     = NULL;
+                            PLSA_TRANSLATED_SID2        pTranslatedSids = NULL;
+                            ntSts = g_pfnLsaLookupNames2(lsahPolicy, 0 /* Flags */,
+                                                         1 /* Number of users to lookup */,
+                                                         &lsaUser, &pDomainList, &pTranslatedSids);
+                            if (ntSts == STATUS_SUCCESS)
+                            {
+                                AssertPtr(pDomainList);
+                                AssertPtr(pTranslatedSids);
 # ifdef DEBUG
-                            LogRelFunc(("LsaLookupNames2: cDomains=%u, DomainIndex=%ld, SidUse=%ld\n",
-                                        pDomainList->Entries, pTranslatedSids[0].DomainIndex, pTranslatedSids[0].Use));
+                                LogRelFunc(("LsaLookupNames2: cDomains=%u, DomainIndex=%ld, SidUse=%ld\n",
+                                            pDomainList->Entries, pTranslatedSids[0].DomainIndex, pTranslatedSids[0].Use));
 # endif
-                            Assert(pTranslatedSids[0].Use == SidTypeUser);
-
-                            if (pDomainList->Entries)
+                                Assert(pTranslatedSids[0].Use == SidTypeUser);
+
+                                if (pDomainList->Entries)
+                                {
+                                    AssertPtr(pDomainList->Domains);
+                                    LogRelFunc(("LsaLookupNames2: Domain=%ls\n",
+                                                pDomainList->Domains[pTranslatedSids[0].DomainIndex].Name.Buffer));
+                                }
+
+                                cbSid = GetLengthSid(pTranslatedSids->Sid) + 16;
+                                Assert(cbSid);
+                                pSid = (PSID)RTMemAllocZ(cbSid);
+                                if (!CopySid(cbSid, pSid, pTranslatedSids->Sid))
+                                {
+                                    dwErr = GetLastError();
+                                    LogRelFunc(("CopySid failed with: %ld\n", dwErr));
+                                    rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_2;
+                                }
+                            }
+                            else if (g_pfnLsaNtStatusToWinError)
                             {
-                                AssertPtr(pDomainList->Domains);
-                                LogRelFunc(("LsaLookupNames2: Domain=%ls\n",
-                                            pDomainList->Domains[pTranslatedSids[0].DomainIndex].Name.Buffer));
-                            }
-
-                            cbSid = GetLengthSid(pTranslatedSids->Sid) + 16;
-                            Assert(cbSid);
-                            pSid = (PSID)RTMemAllocZ(cbSid);
-                            if (!CopySid(cbSid, pSid, pTranslatedSids->Sid))
-                            {
-                                dwErr = GetLastError();
-                                LogRelFunc(("CopySid failed with: %ld\n", dwErr));
+                                dwErr = g_pfnLsaNtStatusToWinError(ntSts);
+                                LogRelFunc(("LsaLookupNames2 failed with: %ld\n", dwErr));
                                 rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_2;
                             }
+                            else
+                            {
+                                LogRelFunc(("LsaLookupNames2 failed with: %#x\n", ntSts));
+                                rc = RTErrConvertFromNtStatus(ntSts);
+                            }
+
+                            if (pDomainList)
+                            {
+                                LsaFreeMemory(pDomainList);
+                                pDomainList = NULL;
+                            }
+                            if (pTranslatedSids)
+                            {
+                                LsaFreeMemory(pTranslatedSids);
+                                pTranslatedSids = NULL;
+                            }
+
+                            rtProcWinFreeAccountInfo(&accountInfo);
+                            LsaClose(lsahPolicy);
                         }
                         else if (g_pfnLsaNtStatusToWinError)
                         {
                             dwErr = g_pfnLsaNtStatusToWinError(ntSts);
-                            LogRelFunc(("LsaLookupNames2 failed with: %ld\n", dwErr));
-                            rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_2;
+                            LogRelFunc(("LsaOpenPolicy failed with: %ld\n", dwErr));
+                            rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_3;
                         }
                         else
                         {
-                            LogRelFunc(("LsaLookupNames2 failed with: %#x\n", ntSts));
+                            LogRelFunc(("LsaOpenPolicy failed with: %#x\n", ntSts));
                             rc = RTErrConvertFromNtStatus(ntSts);
                         }
 
-                        if (pDomainList)
+                        /* Note: pSid will be free'd down below. */
+                    }
+                    else if (dwErr == ERROR_INSUFFICIENT_BUFFER)
+                    {
+                        /* Allocate memory for the LookupAccountNameW output buffers and do it for real. */
+                        cbSid = fRc && cbSid != 0 ? cbSid + 16 : _1K;
+                        pSid = (PSID)RTMemAllocZ(cbSid);
+                        if (pSid)
                         {
-                            LsaFreeMemory(pDomainList);
-                            pDomainList = NULL;
+                            cwcDomain = fRc ? cwcDomain + 2 : _4K;
+                            PRTUTF16 pwszDomain = (PRTUTF16)RTMemAllocZ(cwcDomain * sizeof(RTUTF16));
+                            if (pwszDomain)
+                            {
+                                /* Note: Just pass in the UPN (User Principal Name), e.g. [email protected] */
+                                if (!LookupAccountNameW(NULL /*lpSystemName*/, pwszUser, pSid, &cbSid, pwszDomain, &cwcDomain,
+                                                        &SidNameUse))
+                                {
+                                    dwErr = GetLastError();
+                                    LogRelFunc(("LookupAccountNameW(2) failed with: %ld\n", dwErr));
+                                    rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_4;
+                                }
+
+                                RTMemFree(pwszDomain);
+                            }
+                            else
+                                rc = VERR_NO_MEMORY;
+
+                            /* Note: pSid will be free'd down below. */
                         }
-                        if (pTranslatedSids)
-                        {
-                            LsaFreeMemory(pTranslatedSids);
-                            pTranslatedSids = NULL;
-                        }
-
-                        rtProcWinFreeAccountInfo(&accountInfo);
-                        LsaClose(lsahPolicy);
-                    }
-                    else if (g_pfnLsaNtStatusToWinError)
-                    {
-                        dwErr = g_pfnLsaNtStatusToWinError(ntSts);
-                        LogRelFunc(("LsaOpenPolicy failed with: %ld\n", dwErr));
-                        rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_3;
+                        else
+                            rc = VERR_NO_MEMORY;
                     }
                     else
                     {
-                        LogRelFunc(("LsaOpenPolicy failed with: %#x\n", ntSts));
-                        rc = RTErrConvertFromNtStatus(ntSts);
+                        LogRelFunc(("LookupAccountNameW(1) failed with: %ld\n", dwErr));
+                        rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_2;
                     }
-
-                    /* Note: pSid will be free'd down below. */
                 }
-                else if (dwErr == ERROR_INSUFFICIENT_BUFFER)
-                {
-                    /* Allocate memory for the LookupAccountNameW output buffers and do it for real. */
-                    cbSid = fRc && cbSid != 0 ? cbSid + 16 : _1K;
-                    pSid = (PSID)RTMemAllocZ(cbSid);
-                    if (pSid)
-                    {
-                        cwcDomain = fRc ? cwcDomain + 2 : _4K;
-                        PRTUTF16 pwszDomain = (PRTUTF16)RTMemAllocZ(cwcDomain * sizeof(RTUTF16));
-                        if (pwszDomain)
-                        {
-                            /* Note: Just pass in the UPN (User Principal Name), e.g. [email protected] */
-                            if (!LookupAccountNameW(NULL /*lpSystemName*/, pwszUser, pSid, &cbSid, pwszDomain, &cwcDomain,
-                                                    &SidNameUse))
-                            {
-                                dwErr = GetLastError();
-                                LogRelFunc(("LookupAccountNameW(2) failed with: %ld\n", dwErr));
-                                rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_4;
-                            }
-
-                            RTMemFree(pwszDomain);
-                        }
-                        else
-                            rc = VERR_NO_MEMORY;
-
-                        /* Note: pSid will be free'd down below. */
-                    }
-                    else
-                        rc = VERR_NO_MEMORY;
-                }
-                else
-                {
-                    LogRelFunc(("LookupAccountNameW(1) failed with: %ld\n", dwErr));
-                    rc = dwErr != NO_ERROR ? RTErrConvertFromWin32(dwErr) : VERR_INTERNAL_ERROR_2;
-                }
-            }
-
+            }
+
+            /*
+             * If we got a valid SID, search the running processes.
+             */
             if (pSid)
             {
@@ -1653 +1785 @@
 #ifdef VBOX             /* The explorer entry is a fallback in case GA aren't installed. */
                         { "VBoxTray.exe" },
+# ifndef IN_GUEST
+                        { "VirtualBox.exe" },
+# endif
 #endif
                         { "explorer.exe" },
@@ -1707 +1842 @@
                  */
                 PROFILEINFOW ProfileInfo;
+                PRTUTF16     pwszUserFree = NULL;
                 RT_ZERO(ProfileInfo);
                 if (fFlags & RTPROC_FLAGS_PROFILE)
                 {
-                    ProfileInfo.dwSize     = sizeof(ProfileInfo);
-                    ProfileInfo.lpUserName = pwszUser;
-                    ProfileInfo.dwFlags    = PI_NOUI; /* Prevents the display of profile error messages. */
-
-                    if (!g_pfnLoadUserProfileW(hTokenToUse, &ProfileInfo))
-                        rc = RTErrConvertFromWin32(GetLastError());
+                    if (!pwszUser)
+                    {
+                        Assert(fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN);
+                        rc = rtProcWinTokenToUsername(hTokenToUse, &pwszUserFree);
+                        pwszUser = pwszUserFree;
+                    }
+                    if (RT_SUCCESS(rc))
+                    {
+                        ProfileInfo.dwSize     = sizeof(ProfileInfo);
+                        ProfileInfo.dwFlags    = PI_NOUI; /* Prevents the display of profile error messages. */
+                        ProfileInfo.lpUserName = pwszUser;
+                        if (!g_pfnLoadUserProfileW(hTokenToUse, &ProfileInfo))
+                            rc = RTErrConvertFromWin32(GetLastError());
+                    }
                 }
                 if (RT_SUCCESS(rc))
@@ -1737 +1881 @@
                                     && g_enmWinVer <= kRTWinOSType_NT4) /** @todo test newer versions... */
                                     rtProcWinStationPrep(hTokenToUse, pStartupInfo, &hOldWinStation);
+
+                                /* Specify a window station and desktop when start interactive
+                                 * process from service with an impersonated token. */
+                                /** @todo r=bird: Why is this needed? */
+                                /** @todo r=bird: Why don't we do this for the non-impersonated token case? */
+                                /** @todo r=bird: Remind me, does pure RDP logins get a winSta0 too, or do
+                                 *        the get a mangled name similar to the services? */
+                                if (   fFound
+                                    &&    (fFlags & (RTPROC_FLAGS_SERVICE | RTPROC_FLAGS_AS_IMPERSONATED_TOKEN))
+                                       ==           (RTPROC_FLAGS_SERVICE | RTPROC_FLAGS_AS_IMPERSONATED_TOKEN))
+                                    pStartupInfo->lpDesktop = L"WinSta0\\default";
 
                                 /*
@@ -1795 +1950 @@
 #endif
                     }
+                    if (pwszUserFree)
+                        RTUtf16Free(pwszUserFree);
                 }
             }
@@ -2046 +2203 @@
     /*
      * If we run as a service CreateProcessWithLogon will fail, so don't even
-     * try it (because of Local System context).  This method is very slow on W2K.
-     */
-    if (!(fFlags & RTPROC_FLAGS_SERVICE))
-    {
+     * try it (because of Local System context).  If we got an impersonated token
+     * we should use, we also have to have to skip over this approach.
+     * Note! This method is very slow on W2K.
+     */
+    if (!(fFlags & (RTPROC_FLAGS_SERVICE | RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)))
+    {
+        AssertPtr(pwszUser);
         int rc = rtProcWinCreateAsUser1(pwszUser, pwszPassword, ppwszExec, pwszCmdLine,
                                         hEnv, dwCreationFlags, pStartupInfo, pProcInfo, fFlags, pszExec);
@@ -2227 +2387 @@
     int rc = RTOnce(&g_rtProcWinInitOnce, rtProcWinInitOnce, NULL);
     AssertRCReturn(rc, rc);
-    if (pszAsUser || (fFlags & (RTPROC_FLAGS_PROFILE | RTPROC_FLAGS_SERVICE)))
+    if (pszAsUser || (fFlags & (RTPROC_FLAGS_PROFILE | RTPROC_FLAGS_SERVICE | RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)))
     {
         rc = RTOnce(&g_rtProcWinResolveOnce, rtProcWinResolveOnce, NULL);
@@ -2385 +2545 @@
              */
             if (   pszAsUser == NULL
-                && !(fFlags & RTPROC_FLAGS_SERVICE))
+                && !(fFlags & (RTPROC_FLAGS_SERVICE | RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)))
             {
                 /* Create the environment block first. */
@@ -2414 +2574 @@
                  * function to do the actual work.
                  */
-                PRTUTF16 pwszUser;
-                rc = RTStrToUtf16(pszAsUser, &pwszUser);
+                PRTUTF16 pwszUser = NULL;
+                if (pszAsUser)
+                    rc = RTStrToUtf16(pszAsUser, &pwszUser);
                 if (RT_SUCCESS(rc))
                 {
@@ -2439 +2600 @@
                 {
                     /*
-                     * Add the process to the child process list so
-                     * RTProcWait can reuse and close the process handle.
+                     * Add the process to the child process list so RTProcWait can reuse and close
+                     * the process handle, unless, of course, the caller has no intention waiting.
                      */
-                    rtProcWinAddPid(ProcInfo.dwProcessId, ProcInfo.hProcess);
+                    if (!(fFlags & RTPROC_FLAGS_NO_WAIT))
+                        rtProcWinAddPid(ProcInfo.dwProcessId, ProcInfo.hProcess);
+                    else
+                        CloseHandle(ProcInfo.hProcess);
                     *phProcess = ProcInfo.dwProcessId;
                 }