Changeset 80503 in vbox

Timestamp:

Aug 29, 2019 7:58:42 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

133000

Message:

IPRT/process-win.cpp: More pszUser == NULL + RTPROC_FLAGS_SERVICE considerations (caller should probably not use the flag then, really). bugref:8078

File:

• trunk/src/VBox/Runtime/r3/win/process-win.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/r3/win/process-win.cpp

@@ -1593 +1593 @@
     HANDLE  hTokenLogon = INVALID_HANDLE_VALUE;
     int rc;
-    if (fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)
+    if ((fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN) || pwszUser == NULL)
         rc = rtProcWinGetThreadTokenHandle(GetCurrentThread(), &hTokenLogon);
     else
@@ -1615 +1615 @@
              */
             PSID pSid = NULL;
-            if (fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN)
+            if ((fFlags & RTPROC_FLAGS_AS_IMPERSONATED_TOKEN) || pwszUser == NULL)
                 pSid = rtProcWinGetTokenUserSid(hTokenLogon, &rc);
             else
@@ -1844 +1844 @@
                 PRTUTF16     pwszUserFree = NULL;
                 RT_ZERO(ProfileInfo);
-                if (fFlags & RTPROC_FLAGS_PROFILE)
+                if (fFlags & RTPROC_FLAGS_PROFILE) /** @todo r=bird: We probably don't need to load anything if pwszUser is NULL... */
                 {
                     if (!pwszUser)
@@ -2143 +2143 @@
                                                 NULL,                       /* lpDomain*/
                                                 pwszPassword,
-                                                fFlags & RTPROC_FLAGS_PROFILE ? 1 /*LOGON_WITH_ PROFILE*/ : 0,
+                                                fFlags & RTPROC_FLAGS_PROFILE ? 1 /*LOGON_WITH_PROFILE*/ : 0,
                                                 *ppwszExec,
                                                 pwszCmdLine,