Changeset 80520 in vbox

Timestamp:

Aug 30, 2019 6:30:16 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9510: Caching some more translatable strings

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIInformationRuntime.cpp (modified) (13 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIInformationRuntime.cpp

@@ -89 +89 @@
 
     void runTimeAttributes();
+    QString screenResolutions();
+
     void insertInfoLine(InfoLine enmInfoLine, const QString& strLabel, const QString &strInfo);
     void computeMinimumWidth();
@@ -99 +101 @@
         QString m_strTableTitle;
         QString m_strScreenResolutionLabel;
+        QString m_strMonitorTurnedOff;
         QString m_strUptimeLabel;
         QString m_strClipboardModeLabel;
@@ -106 +109 @@
         QString m_strUnrestrictedExecutionLabel;
         QString m_strParavirtualizationLabel;
+        QString m_strActive;
+        QString m_strInactive;
+        QString m_strNotAvailable;
         QString m_strGuestAdditionsLabel;
         QString m_strGuestOSTypeLabel;
         QString m_strRemoteDesktopLabel;
+        QString m_strNotSet;
+        QString m_strNotDetected;
     /** @} */
 
@@ -236 +244 @@
     m_strTableTitle = QApplication::translate("UIVMInformationDialog", "Runtime Attributes");
     m_strScreenResolutionLabel = QApplication::translate("UIVMInformationDialog", "Screen Resolution");
+    m_strMonitorTurnedOff = QApplication::translate("UIVMInformationDialog", "turned off");
     m_strUptimeLabel = QApplication::translate("UIVMInformationDialog", "VM Uptime");
     m_strClipboardModeLabel = QApplication::translate("UIVMInformationDialog", "Clipboard Mode");
@@ -243 +252 @@
     m_strUnrestrictedExecutionLabel = QApplication::translate("UIVMInformationDialog", "Unrestricted Execution");
     m_strParavirtualizationLabel = QApplication::translate("UIVMInformationDialog", "Paravirtualization Interface");
+    m_strActive = QApplication::translate("UIVMInformationDialog", "Active");
+    m_strInactive = QApplication::translate("UIVMInformationDialog", "Inactive");
+    m_strNotAvailable = QApplication::translate("UIVMInformationDialog", "Not Available");
     m_strGuestAdditionsLabel = QApplication::translate("UIVMInformationDialog", "Guest Additions");
     m_strGuestOSTypeLabel = QApplication::translate("UIVMInformationDialog", "Guest OS Type");
     m_strRemoteDesktopLabel = QApplication::translate("UIVMInformationDialog", "Remote Desktop Server Port");
+    m_strNotSet = QApplication::translate("UIVMInformationDialog", "not set");
+    m_strNotDetected = QApplication::translate("UIVMInformationDialog", "Not Detected");
 }
 
@@ -266 +280 @@
     setItem(iRow, 1, new QTableWidgetItem(strInfo, enmInfoLine));
     setRowHeight(iRow, 2 * iMargin + m_iFontHeight);
+}
+
+QString UIRuntimeInfoWidget::screenResolutions()
+{
+    QString strResolutions;
+    return strResolutions;
 }
 
@@ -289 +309 @@
         {
             strResolution += QString(" ");
-            strResolution += QString(QApplication::translate("UIVMInformationDialog", "turned off"));
+            strResolution += m_strMonitorTurnedOff;
         }
         aResolutions[iScreen] = strResolution;
@@ -315 +335 @@
     /* Determine virtualization attributes: */
     QString strVirtualization = debugger.GetHWVirtExEnabled() ?
-        QApplication::translate("UIVMInformationDialog", "Active") :
-        QApplication::translate("UIVMInformationDialog", "Inactive");
+        m_strActive : m_strInactive;
 
     QString strExecutionEngine;
@@ -334 +353 @@
             RT_FALL_THRU();
         case KVMExecutionEngine_NotSet:
-            strExecutionEngine = QApplication::translate("UIVMInformationDialog", "not set");
+            strExecutionEngine = m_strNotSet;
             break;
     }
     QString strNestedPaging = debugger.GetHWVirtExNestedPagingEnabled() ?
-        QApplication::translate("UIVMInformationDialog", "Active"):
-        QApplication::translate("UIVMInformationDialog", "Inactive");
+        m_strActive : m_strInactive;
 
     QString strUnrestrictedExecution = debugger.GetHWVirtExUXEnabled() ?
-        QApplication::translate("UIVMInformationDialog", "Active"):
-        QApplication::translate("UIVMInformationDialog", "Inactive");
-
-        QString strParavirtProvider = gpConverter->toString(m_machine.GetEffectiveParavirtProvider());
+        m_strActive : m_strInactive;
+
+    QString strParavirtProvider = gpConverter->toString(m_machine.GetEffectiveParavirtProvider());
 
     /* Guest information: */
@@ -351 +368 @@
     QString strGAVersion = guest.GetAdditionsVersion();
     if (strGAVersion.isEmpty())
-        strGAVersion = tr("Not Detected", "guest additions");
+        strGAVersion = m_strNotDetected;
     else
     {
@@ -360 +377 @@
     QString strOSType = guest.GetOSTypeId();
     if (strOSType.isEmpty())
-        strOSType = tr("Not Detected", "guest os type");
+        strOSType = m_strNotDetected;
     else
         strOSType = uiCommon().vmGuestOSTypeDescription(strOSType);
@@ -367 +384 @@
     int iVRDEPort = m_console.GetVRDEServerInfo().GetPort();
     QString strVRDEInfo = (iVRDEPort == 0 || iVRDEPort == -1)?
-        tr("Not Available", "details report (VRDE server port)") :
-        QString("%1").arg(iVRDEPort);
+        m_strNotAvailable : QString("%1").arg(iVRDEPort);
 
     /* Searching for longest string: */
@@ -539 +555 @@
 {
     int iFontSize = 24;
-
-    //const QString &strText = m_pMetric->name();
     foreach (const QString &strText, m_textList)
     {
         m_font.setPixelSize(iFontSize);
-
         do{
             int iWidth = QFontMetrics(m_font).width(strText);