Changeset 80698 in vbox for trunk/src/VBox

Timestamp:

Sep 10, 2019 12:27:41 PM (5 years ago)

Author:

vboxsync

Message:

ValKit/vboxinstaller.py: Upload the log if we had/have any leftover devices.

File:

• trunk/src/VBox/ValidationKit/testdriver/vboxinstaller.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testdriver/vboxinstaller.py

@@ -922 +922 @@
         self._waitForTestManagerConnectivity(30);
 
+        # Upload the log on failure.  Do it early if the extra cleanups below causes trouble.
         if fRc is False and os.path.isfile(sLogFile):
             reporter.addLogFile(sLogFile, 'log/uninstaller', "Verbose MSI uninstallation log file");
+            sLogFile = None;
 
         # Log driver service states (should ls \Driver\VBox* and \Device\VBox*).
@@ -963 +965 @@
         if fHadLeftovers:
             self._waitForTestManagerConnectivity(30);
+
+        # Upload the log if we have any leftovers and didn't upload it already.
+        if sLogFile is not None and (fRc is False or fHadLeftovers) and os.path.isfile(sLogFile):
+            reporter.addLogFile(sLogFile, 'log/uninstaller', "Verbose MSI uninstallation log file");
 
         return fRc;