Changeset 80818 in vbox for trunk/src

Timestamp:

Sep 16, 2019 10:35:16 AM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:8938. Removing qobject_cast's in connection calls.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineLogicFullscreen.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineLogicFullscreen.cpp

@@ -547 +547 @@
         foreach (UIMachineWindow *pMachineWindow, machineWindows())
         {
+            UIMachineWindowFullscreen *pMachineWindowFullscreen = qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow);
+            if (!pMachineWindow)
+                continue;
             /* Logic => window signals: */
             connect(this, &UIMachineLogicFullscreen::sigNotifyAboutNativeFullscreenShouldBeEntered,
-                    qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sltEnterNativeFullscreen);
+                    pMachineWindowFullscreen, &UIMachineWindowFullscreen::sltEnterNativeFullscreen);
             connect(this, &UIMachineLogicFullscreen::sigNotifyAboutNativeFullscreenShouldBeExited,
-                    qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sltExitNativeFullscreen);
+                    pMachineWindowFullscreen, &UIMachineWindowFullscreen::sltExitNativeFullscreen);
             /* Window => logic signals: */
-            connect(qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenWillEnter,
+            connect(pMachineWindowFullscreen, &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenWillEnter,
                     this, &UIMachineLogicFullscreen::sltHandleNativeFullscreenWillEnter,
                      Qt::QueuedConnection);
-            connect(qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenDidEnter,
+            connect(pMachineWindowFullscreen, &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenDidEnter,
                     this, &UIMachineLogicFullscreen::sltHandleNativeFullscreenDidEnter,
                     Qt::QueuedConnection);
-            connect(qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenWillExit,
+            connect(pMachineWindowFullscreen, &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenWillExit,
                     this, &UIMachineLogicFullscreen::sltHandleNativeFullscreenWillExit,
                     Qt::QueuedConnection);
-            connect(qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenDidExit,
+            connect(pMachineWindowFullscreen, &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenDidExit,
                     this, &UIMachineLogicFullscreen::sltHandleNativeFullscreenDidExit,
                     Qt::QueuedConnection);
-            connect(qobject_cast<UIMachineWindowFullscreen*>(pMachineWindow), &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenFailToEnter,
+            connect(pMachineWindowFullscreen, &UIMachineWindowFullscreen::sigNotifyAboutNativeFullscreenFailToEnter,
                     this, &UIMachineLogicFullscreen::sltHandleNativeFullscreenFailToEnter,
                     Qt::QueuedConnection);