Changeset 80833 in vbox

Timestamp:

Sep 16, 2019 7:59:03 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

133403

Message:

GuestSessionTask::fileCopyToGuest: More review comments. bugref:9320

File:

• trunk/src/VBox/Main/src-client/GuestSessionImplTasks.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/GuestSessionImplTasks.cpp

@@ -801 +801 @@
     Utf8Str strDestFinal = strDest;
 
+    /** @todo r=bird: Why do we need to do this here?  It's a waste of time (extra
+     *        IPC) for 99% of the calls, it only does something useful if the
+     *        destination is a directory, and you should be able to handle that just
+     *        as efficiently in the i_fileOpen() failure path. */
     GuestFsObjData dstObjData;
     int rcGuest = VERR_IPE_UNINITIALIZED_STATUS;
@@ -829 +833 @@
                 /** @todo r=bird: You're totally ignoring the guest slash-style here! Callers
                  *        should have this info. */
+                /** @todo r=bird: This is wrong even on windows if strDest is 'C:' and the
+                 *        current working directory (CWD) isn't the root of the drive. :-) */
                 if (   !strDest.endsWith("\\")
                     && !strDest.endsWith("/"))
@@ -849 +855 @@
                 break;
 
+            /** @todo r=brent,r=bird: you follow symlinks, so this cannot happen at present.
+             *        That said, maybe it isn't intentional to always follow symlinks? */
             case FsObjType_Symlink:
-                if (!(fFileCopyFlags & FileCopyFlag_FollowLinks))
+                 if (!(fFileCopyFlags & FileCopyFlag_FollowLinks))
                 {
                     setProgressErrorMsg(VBOX_E_IPRT_ERROR,