Changeset 80855 in vbox for trunk

Timestamp:

Sep 17, 2019 12:33:54 PM (5 years ago)

Author:

vboxsync

Message:

RTSystemFirmware-generic.cpp: Kick out unnecessary headers and assertions from the generic code. Enums shall use the 'enm' prefix in IPRT. Leaving the s/RTSystemFirmwareValueGet/RTSystemFirmwareValueQuery/ renaming to the dev working on the code.

Location:

trunk

Files:

• include/iprt/system.h (modified) (1 diff)
• src/VBox/Runtime/generic/RTSystemFirmware-generic.cpp (modified) (2 diffs)

trunk/include/iprt/system.h

@@ -280 +280 @@
  * Queries the system's firmware type.
  *
- * @retval  IPRT status code.
- * @param   pFirmwareType       Where to store the firmware type on success.
- */
-RTDECL(int) RTSystemFirmwareQueryType(PRTSYSFWTYPE pFirmwareType);
+ * @returns  IPRT status code.
+ * @param   penmType    Where to return the firmware type on success.
+ */
+RTDECL(int) RTSystemFirmwareQueryType(PRTSYSFWTYPE penmType);
 
 /**

trunk/src/VBox/Runtime/generic/RTSystemFirmware-generic.cpp

@@ -29 +29 @@
 *   Header Files                                                                                                                 *
 *********************************************************************************************************************************/
+#include "internal/iprt.h"
+#include <iprt/system.h>
 
-#include <iprt/assert.h>
 #include <iprt/errcore.h>
-#include <iprt/ldr.h>
-#include <iprt/system.h>
-#include "internal/iprt.h"
 
 
-/*********************************************************************************************************************************
-*   Structures and Typedefs                                                                                                      *
-*********************************************************************************************************************************/
-
-
-RTDECL(int) RTSystemFirmwareQueryType(PRTSYSFWTYPE pFirmwareType)
+RTDECL(int) RTSystemFirmwareQueryType(PRTSYSFWTYPE penmFirmwareType)
 {
-    AssertPtrReturn(pFirmwareType, VERR_INVALID_POINTER);
-
     return VERR_NOT_SUPPORTED;
 }
@@ -60 +51 @@
 RTDECL(int) RTSystemFirmwareValueGet(RTSYSFWPROP enmProp, PRTSYSFWVALUE *ppValue)
 {
-    AssertPtrReturn(ppValue, VERR_INVALID_POINTER);
-
     RT_NOREF(enmProp, ppValue);
-
     return VERR_NOT_SUPPORTED;
 }
 RT_EXPORT_SYMBOL(RTSystemFirmwareValueGet);
+