Changeset 81146 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Oct 8, 2019 11:44:13 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

133780

Message:

FE/Qt: bugref:9582: VM settings / Storage page: Do not change controller type if bus change failed/discarded.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -3751 +3751 @@
             else if (pSender == mCbType)
             {
-                m_pModelStorage->setData(index,
-                                         QVariant::fromValue(mCbType->currentData(StorageModel::R_CtrBusType).value<KStorageBus>()),
-                                         StorageModel::R_CtrBusType);
-                m_pModelStorage->setData(index,
-                                         QVariant::fromValue(mCbType->currentData(StorageModel::R_CtrType).value<KStorageControllerType>()),
-                                         StorageModel::R_CtrType);
+                const bool fResult =
+                    m_pModelStorage->setData(index,
+                                             QVariant::fromValue(mCbType->currentData(StorageModel::R_CtrBusType).value<KStorageBus>()),
+                                             StorageModel::R_CtrBusType);
+                if (fResult)
+                    m_pModelStorage->setData(index,
+                                             QVariant::fromValue(mCbType->currentData(StorageModel::R_CtrType).value<KStorageControllerType>()),
+                                             StorageModel::R_CtrType);
             }
             else if (pSender == mSbPortCount)