Changeset 81196 in vbox

Timestamp:

Oct 9, 2019 8:24:12 PM (5 years ago)

Author:

vboxsync

Message:

EFI/Firmware: Applied the SplitPage fix to the copy in CpuMpPei too as well as surrounding page entry updates that I could easily spot. bugref:4643

File:

• trunk/src/VBox/Devices/EFI/Firmware/UefiCpuPkg/CpuMpPei/CpuPaging.c (modified) (9 diffs)

trunk/src/VBox/Devices/EFI/Firmware/UefiCpuPkg/CpuMpPei/CpuPaging.c

@@ -13 +13 @@
 #include <Library/CpuLib.h>
 #include <Library/BaseLib.h>
+#ifdef VBOX
+# define IN_RING0
+# include <iprt/asm.h>
+#endif
 
 #include "CpuMpPei.h"
@@ -68 +72 @@
 };
 
+#ifdef VBOX
+/**
+ Safe page table entry write function, make 104% sure the compiler won't
+ split up the access (fatal if modifying entries for current code or data).
+
+ @param[in] PageEntry        The page table entry to modify.*
+ @param[in] CurrentPageEntry The old page table value (for cmpxchg8b).
+ @param[in] NewPageEntry     What to write.
+**/
+static VOID SafePageTableEntryWrite64 (UINT64 volatile *PageEntry, UINT64 CurrentPageEntry, UINT64 NewPageEntry)
+{
+# ifdef VBOX
+  ASMAtomicWriteU64(PageEntry, NewPageEntry); RT_NOREF(CurrentPageEntry);
+# else
+  for (;;) {
+    UINT64 CurValue = InterlockedCompareExchange64(PageEntry, CurrentPageEntry, NewPageEntry);
+    if (CurValue == CurrentPageEntry)
+      return;
+    CurrentPageEntry = CurValue;
+  }
+# endif
+}
+#endif
+
 /**
   The function will check if IA32 PAE is supported.
@@ -235 +263 @@
 RETURN_STATUS
 SplitPage (
+#ifdef VBOX
+  IN  UINT64 volatile                   *PageEntry,
+#else
   IN  UINT64                            *PageEntry,
+#endif
   IN  PAGE_ATTRIBUTE                    PageAttribute,
   IN  PAGE_ATTRIBUTE                    SplitAttribute,
@@ -241 +273 @@
   )
 {
+#ifdef VBOX
+  UINT64            CurrentPageEntry;
+#endif
   UINT64            BaseAddress;
   UINT64            *NewPageEntry;
@@ -265 +300 @@
   AddressEncMask = PcdGet64 (PcdPteMemoryEncryptionAddressOrMask) &
                    mPageAttributeTable[SplitTo].AddressMask;
+#ifdef VBOX
+  CurrentPageEntry = *PageEntry;
+  BaseAddress    = CurrentPageEntry &
+#else
   BaseAddress    = *PageEntry &
+#endif
                    ~PcdGet64 (PcdPteMemoryEncryptionAddressOrMask) &
                    mPageAttributeTable[PageAttribute].AddressMask;
   for (Index = 0; Index < SIZE_4KB / sizeof(UINT64); Index++) {
     NewPageEntry[Index] = BaseAddress | AddressEncMask |
+#ifdef VBOX
+                          (CurrentPageEntry & PAGE_PROGATE_BITS);
+#else
                           ((*PageEntry) & PAGE_PROGATE_BITS);
+#endif
 
     if (SplitTo != PageMin) {
@@ -283 +327 @@
   }
 
+#ifdef VBOX
+  SafePageTableEntryWrite64 (PageEntry, CurrentPageEntry,
+                             (UINT64)(UINTN)NewPageEntry | AddressEncMask | PAGE_ATTRIBUTE_BITS);
+#else
   (*PageEntry) = (UINT64)(UINTN)NewPageEntry | AddressEncMask | PAGE_ATTRIBUTE_BITS;
+#endif
 
   return RETURN_SUCCESS;
@@ -318 +367 @@
   )
 {
+#ifdef VBOX
+  UINT64 volatile                   *PageEntry;
+  UINT64                            CurrentPageEntry;
+#else
   UINT64                            *PageEntry;
+#endif
   PAGE_ATTRIBUTE                    PageAttribute;
   RETURN_STATUS                     Status;
@@ -364 +418 @@
     // Just take care of 'present' bit for Stack Guard.
     //
+#ifdef VBOX
+    CurrentPageEntry = *PageEntry;
+    if ((CurrentPageEntry & IA32_PG_P) != (Attributes & IA32_PG_P))
+      SafePageTableEntryWrite64 (PageEntry, CurrentPageEntry,
+                                 (CurrentPageEntry & ~(UINT64)IA32_PG_P) | (Attributes & IA32_PG_P));
+#else
     if ((Attributes & IA32_PG_P) != 0) {
       *PageEntry |= (UINT64)IA32_PG_P;
@@ -369 +429 @@
       *PageEntry &= ~((UINT64)IA32_PG_P);
     }
+#endif
 
     //