Changeset 81336 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Oct 18, 2019 1:03:10 AM (5 years ago)

Author:

vboxsync

Message:

IOM: Implemented the IOMMMIO_FLAGS_ABS flag (or rather the absence of it). bugref:9218

File:

• trunk/src/VBox/VMM/include/IOMInternal.h (modified) (4 diffs)

trunk/src/VBox/VMM/include/IOMInternal.h

@@ -328 +328 @@
     /** The number of bytes covered by this entry. */
     RTGCPHYS                            cbRegion;
-    /** The current mapping address (duplicates lookup table). */
-    RTGCPHYS                            GCPhysMapping;
+    /** The current mapping address (duplicates lookup table).
+     * This is set to NIL_RTGCPHYS if not mapped (exclusive lock + atomic). */
+    RTGCPHYS volatile                   GCPhysMapping;
     /** Pointer to user argument. */
     RTR3PTR                             pvUser;
@@ -352 +353 @@
     uint16_t                            idxStats;
     /** Set if mapped, clear if not.
-     * Only updated when critsect is held exclusively.   */
-    bool                                fMapped;
+     * Only updated when critsect is held exclusively.
+     * @todo remove as GCPhysMapping != NIL_RTGCPHYS serves the same purpose. */
+    bool volatile                       fMapped;
     /** Set if there is an ring-0 entry too. */
     bool                                fRing0;
@@ -631 +633 @@
     /** I/O port registration index for the last write string operation. */
     uint16_t                            idxIoPortLastWriteStr;
-    uint32_t                            u32Padding;
+
+    /** MMIO port registration index for the last IOMR3MmioPhysHandler call.
+     * @note pretty static as only used by APIC on AMD-V.  */
+    uint16_t                            idxMmioLastPhysHandler;
+    uint16_t                            u16Padding;
 
     R3PTRTYPE(PIOMIOPORTRANGER3)    pRangeLastReadR3;
@@ -739 +745 @@
     /** @name MMIO statistics.
      * @{ */
+    STAMCOUNTER                     StatRZMMIOStaleMappings;
     STAMPROFILE                     StatRZMMIOHandler;
     STAMCOUNTER                     StatRZMMIOReadsToR3;