Changeset 81394 in vbox for trunk/src/VBox/Main/include

Timestamp:

Oct 21, 2019 9:16:17 AM (5 years ago)

Author:

vboxsync

Message:

Main/MachineImplMoveVM: Putting all Machine object references in a global variable is impossible, since multiple VM move operations can operate concurrently.

File:

• trunk/src/VBox/Main/include/MachineImplMoveVM.h (modified) (2 diffs)

trunk/src/VBox/Main/include/MachineImplMoveVM.h

@@ -66 +66 @@
 class MachineMoveVM : public ThreadTask
 {
+    std::vector<ComObjPtr<Machine> >        machineList;
     RTCList<MEDIUMTASKCHAINMOVE>            m_llMedias;
     RTCList<SAVESTATETASKMOVE>              m_llSaveStateFiles;
@@ -110 +111 @@
 
 private:
-    HRESULT createMachineList(const ComPtr<ISnapshot> &pSnapshot, std::vector<ComObjPtr<Machine> > &aMachineList) const;
+    HRESULT createMachineList(const ComPtr<ISnapshot> &pSnapshot);
     inline HRESULT queryBaseName(const ComPtr<IMedium> &pMedium, Utf8Str &strBaseName) const;
-    HRESULT queryMediasForAllStates(const std::vector<ComObjPtr<Machine> > &aMachineList);
+    HRESULT queryMediasForAllStates();
     void updateProgressStats(MEDIUMTASKCHAINMOVE &mtc, ULONG &uCount, ULONG &uTotalWeight) const;
     HRESULT addSaveState(const ComObjPtr<Machine> &machine);