Changeset 81417 in vbox

Timestamp:

Oct 21, 2019 3:22:15 PM (5 years ago)

Author:

vboxsync

Message:

DevE1000: Eliminating hCanRxTask (previously pCanRxQueue) by replacing hEventMoreRxDescAvail with a SUPSEMEVENT than can be signalled from ring-0. This probably changes the EMT run pattern quite abit, since we used to force a lot of trips back to ring-3 to service the queue there for no good reason. bugref:9218

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (14 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -1048 +1048 @@
     /** Transmit task. */
     PDMTASKHANDLE           hTxTask;
-    /** Rx wakeup signaller. */
-    PDMTASKHANDLE           hCanRxTask;
 
     /** Critical section - what is it protecting? */
@@ -1110 +1108 @@
     bool volatile fMaybeOutOfSpace;
     /** EMT: Gets signalled when more RX descriptors become available. */
-    RTSEMEVENT  hEventMoreRxDescAvail;
+    SUPSEMEVENT hEventMoreRxDescAvail;
 #ifdef E1K_WITH_RXD_CACHE
     /** RX: Fetched RX descriptors. */
@@ -1209 +1207 @@
     STAMPROFILE                         StatTransmitSendR3;
     STAMPROFILE                         StatRxOverflow;
-    STAMCOUNTER                         StatRxOverflowWakeup;
+    STAMCOUNTER                         StatRxOverflowWakeupRZ;
+    STAMCOUNTER                         StatRxOverflowWakeupR3;
     STAMCOUNTER                         StatTxDescCtxNormal;
     STAMCOUNTER                         StatTxDescCtxTSE;
@@ -1671 +1670 @@
 #endif /* E1K_WITH_TX_CS */
 
+
+/**
+ * Wakeup the RX thread.
+ */
+static void e1kWakeupReceive(PPDMDEVINS pDevIns, PE1KSTATE pThis)
+{
+    if (   pThis->fMaybeOutOfSpace
+        && pThis->hEventMoreRxDescAvail != NIL_SUPSEMEVENT)
+    {
+        STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatRxOverflowWakeup));
+        E1kLog(("%s Waking up Out-of-RX-space semaphore\n",  pThis->szPrf));
+        int rc = PDMDevHlpSUPSemEventSignal(pDevIns, pThis->hEventMoreRxDescAvail);
+        AssertRC(rc);
+    }
+}
+
 #ifdef IN_RING3
-
-/**
- * Wakeup the RX thread.
- */
-static void e1kWakeupReceive(PPDMDEVINS pDevIns)
-{
-    PE1KSTATE pThis = PDMINS_2_DATA(pDevIns, PE1KSTATE);
-    if (    pThis->fMaybeOutOfSpace
-        &&  pThis->hEventMoreRxDescAvail != NIL_RTSEMEVENT)
-    {
-        STAM_COUNTER_INC(&pThis->StatRxOverflowWakeup);
-        E1kLog(("%s Waking up Out-of-RX-space semaphore\n",  pThis->szPrf));
-        RTSemEventSignal(pThis->hEventMoreRxDescAvail);
-    }
-}
 
 /**
@@ -3339 +3339 @@
         if (RT_SUCCESS(rc))
         {
-/** @todo bird: Use SUPSem* for this so we can signal it in ring-0 as well
- *        without requiring any context switches.  We should also check the
- *        wait condition before bothering to queue the item as we're currently
- *        queuing thousands of items per second here in a normal transmit
- *        scenario.  Expect performance changes when fixing this! */
-#ifdef IN_RING3
             /* Signal that we have more receive descriptors available. */
-            e1kWakeupReceive(pDevIns);
-#else
-            PDMDevHlpTaskTrigger(pDevIns, pThis->hCanRxTask);
-#endif
+            e1kWakeupReceive(pDevIns, pThis);
         }
     }
@@ -5619 +5610 @@
 {
     RT_NOREF(pvUser);
-    e1kWakeupReceive(pDevIns);
+    e1kWakeupReceive(pDevIns, PDMINS_2_DATA(pDevIns, PE1KSTATE));
 }
 
@@ -6498 +6489 @@
         E1kLogRel(("E1000: e1kR3NetworkDown_WaitReceiveAvail: waiting cMillies=%u...\n", cMillies));
         E1kLog(("%s: e1kR3NetworkDown_WaitReceiveAvail: waiting cMillies=%u...\n", pThis->szPrf, cMillies));
-        RTSemEventWait(pThis->hEventMoreRxDescAvail, cMillies);
+        PDMDevHlpSUPSemEventWaitNoResume(pDevIns, pThis->hEventMoreRxDescAvail, cMillies);
     }
     STAM_PROFILE_STOP(&pThis->StatRxOverflow, a);
@@ -7548 +7539 @@
 {
     /* Poke thread waiting for buffer space. */
-    e1kWakeupReceive(pDevIns);
+    e1kWakeupReceive(pDevIns, PDMINS_2_DATA(pDevIns, PE1KSTATE));
 }
 
@@ -7580 +7571 @@
 {
     /* Poke thread waiting for buffer space. */
-    e1kWakeupReceive(pDevIns);
+    e1kWakeupReceive(pDevIns, PDMINS_2_DATA(pDevIns, PE1KSTATE));
 }
 
@@ -7625 +7616 @@
     if (PDMCritSectIsInitialized(&pThis->cs))
     {
-        if (pThis->hEventMoreRxDescAvail != NIL_RTSEMEVENT)
-        {
-            RTSemEventSignal(pThis->hEventMoreRxDescAvail);
-            RTSemEventDestroy(pThis->hEventMoreRxDescAvail);
-            pThis->hEventMoreRxDescAvail = NIL_RTSEMEVENT;
+        if (pThis->hEventMoreRxDescAvail != NIL_SUPSEMEVENT)
+        {
+            PDMDevHlpSUPSemEventSignal(pDevIns, pThis->hEventMoreRxDescAvail);
+            RTThreadYield();
+            PDMDevHlpSUPSemEventClose(pDevIns, pThis->hEventMoreRxDescAvail);
+            pThis->hEventMoreRxDescAvail = NIL_SUPSEMEVENT;
         }
 #ifdef E1K_WITH_TX_CS
@@ -7730 +7722 @@
     RTStrPrintf(pThis->szPrf, sizeof(pThis->szPrf), "E1000#%d", iInstance);
     E1kLog(("%s Constructing new instance sizeof(E1KRXDESC)=%d\n", pThis->szPrf, sizeof(E1KRXDESC)));
-    pThis->hEventMoreRxDescAvail = NIL_RTSEMEVENT;
+    pThis->hEventMoreRxDescAvail = NIL_SUPSEMEVENT;
     pThis->u16TxPktLen  = 0;
     pThis->fIPcsum      = false;
@@ -7926 +7918 @@
     AssertRCReturn(rc, rc);
 
-    /* Create the RX notifier signaller. */
-    rc = PDMDevHlpTaskCreate(pDevIns, PDMTASK_F_RZ, "E1000-Rcv", e1kCanRxTaskCallback, NULL, &pThis->hCanRxTask);
-    AssertRCReturn(rc, rc);
-
 #ifdef E1K_TX_DELAY
     /* Create Transmit Delay Timer */
@@ -8014 +8002 @@
         return PDMDEV_SET_ERROR(pDevIns, rc, N_("Failed to attach the network LUN"));
 
-    rc = RTSemEventCreate(&pThis->hEventMoreRxDescAvail);
+    rc = PDMDevHlpSUPSemEventCreate(pDevIns, &pThis->hEventMoreRxDescAvail);
     AssertRCReturn(rc, rc);
 
@@ -8048 +8036 @@
     PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatReceiveStore,       STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL, "Profiling receive storing",          "/Devices/E1k%d/Receive/Store", iInstance);
     PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatRxOverflow,         STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_OCCURENCE, "Profiling RX overflows",        "/Devices/E1k%d/RxOverflow", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatRxOverflowWakeup,   STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of RX overflow wakeups",          "/Devices/E1k%d/RxOverflowWakeup", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatRxOverflowWakeupRZ, STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of RX overflow wakeups in RZ",    "/Devices/E1k%d/RxOverflowWakeupRZ", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatRxOverflowWakeupR3, STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of RX overflow wakeups in R3",    "/Devices/E1k%d/RxOverflowWakeupR3", iInstance);
     PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatTransmitRZ,         STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL, "Profiling transmits in RZ",          "/Devices/E1k%d/Transmit/TotalRZ", iInstance);
     PDMDevHlpSTAMRegisterF(pDevIns, &pThis->StatTransmitR3,         STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL, "Profiling transmits in R3",          "/Devices/E1k%d/Transmit/TotalR3", iInstance);