Changeset 81485 in vbox for trunk

Timestamp:

Oct 23, 2019 10:28:49 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

134210

Message:

FlashCore: Must check SMMR3Get* status codes before using the value.

File:

• trunk/src/VBox/Devices/EFI/FlashCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/EFI/FlashCore.cpp

@@ -365 +365 @@
 
         /* Make sure configuration didn't change behind our back. */
-        SSMR3GetU16(pSSM, &u16Val);
+        rc = SSMR3GetU16(pSSM, &u16Val);
+        AssertRCReturn(rc, rc);
         if (u16Val != pThis->cbBlockSize)
             return VERR_SSM_LOAD_CONFIG_MISMATCH;
-        SSMR3GetU16(pSSM, &u16Val);
+        rc = SSMR3GetU16(pSSM, &u16Val);
+        AssertRCReturn(rc, rc);
         if (u16Val != pThis->u16FlashId)
             return VERR_SSM_LOAD_CONFIG_MISMATCH;
-        SSMR3GetU32(pSSM, &u32Val);
+        rc = SSMR3GetU32(pSSM, &u32Val);
+        AssertRCReturn(rc, rc);
         if (u32Val != pThis->cbFlashSize)
             return VERR_SSM_LOAD_CONFIG_MISMATCH;
 
         /* Suck in the flash contents. */
-        SSMR3GetMem(pSSM, pThis->pbFlash, pThis->cbFlashSize);
+        rc = SSMR3GetMem(pSSM, pThis->pbFlash, pThis->cbFlashSize);
     }
     else