Changeset 81613 in vbox for trunk/include/iprt

Timestamp:

Oct 31, 2019 6:50:08 PM (5 years ago)

Author:

vboxsync

Message:

VMM,SUPDrv,x86.h: Nits.

• supdrvTscMeasureDeltaOne: No bulldozer Hygon, right, so don't muddle complicated if expression with impossibilities.
• CPUMMICROARCH: Put the Hygon and Shanghai immediately after the CPU families they are derived from (in the enum).
• cpumR3CpuIdExplodeFeatures: No K7 Hygon, right, so just flag all Hygons having leaking FxSR when FFXSR is set.
• cpumR3LoadCpuIdInner: Incorrect indent.
• getMsrNameHandled: Unnecessary parentheses and space.

File:

• trunk/include/iprt/asm-amd64-x86.h (modified) (5 diffs)

trunk/include/iprt/asm-amd64-x86.h

@@ -1476 +1476 @@
 DECLINLINE(bool) ASMIsIntelCpuEx(uint32_t uEBX, uint32_t uECX, uint32_t uEDX)
 {
-    return uEBX == UINT32_C(0x756e6547)
-        && uECX == UINT32_C(0x6c65746e)
-        && uEDX == UINT32_C(0x49656e69);
+    /* 'GenuineIntel' */
+    return uEBX == UINT32_C(0x756e6547)     /* 'Genu' */
+        && uEDX == UINT32_C(0x49656e69)     /* 'ineI' */
+        && uECX == UINT32_C(0x6c65746e);    /* 'ntel' */
 }
 
@@ -1506 +1507 @@
 DECLINLINE(bool) ASMIsAmdCpuEx(uint32_t uEBX, uint32_t uECX, uint32_t uEDX)
 {
-    return uEBX == UINT32_C(0x68747541)
-        && uECX == UINT32_C(0x444d4163)
-        && uEDX == UINT32_C(0x69746e65);
+    /* 'AuthenticAMD' */
+    return uEBX == UINT32_C(0x68747541)     /* 'Auth' */
+        && uEDX == UINT32_C(0x69746e65)     /* 'enti' */
+        && uECX == UINT32_C(0x444d4163);    /* 'dAMD' */
 }
 
@@ -1536 +1538 @@
 DECLINLINE(bool) ASMIsViaCentaurCpuEx(uint32_t uEBX, uint32_t uECX, uint32_t uEDX)
 {
-    return uEBX == UINT32_C(0x746e6543)
-        && uECX == UINT32_C(0x736c7561)
-        && uEDX == UINT32_C(0x48727561);
+    /* 'CentaurHauls' */
+    return uEBX == UINT32_C(0x746e6543)     /* 'Cent' */
+        && uEDX == UINT32_C(0x48727561)     /* 'aurH' */
+        && uECX == UINT32_C(0x736c7561);    /* 'auls' */
 }
 
@@ -1566 +1569 @@
 DECLINLINE(bool) ASMIsShanghaiCpuEx(uint32_t uEBX, uint32_t uECX, uint32_t uEDX)
 {
-    return uEBX == UINT32_C(0x68532020)
-        && uECX == UINT32_C(0x20206961)
-        && uEDX == UINT32_C(0x68676e61);
+    /* '  Shanghai  ' */
+    return uEBX == UINT32_C(0x68532020)     /* '  Sh' */
+        && uEDX == UINT32_C(0x68676e61)     /* 'angh' */
+        && uECX == UINT32_C(0x20206961);    /* 'ai  ' */
 }
 
@@ -1596 +1600 @@
 DECLINLINE(bool) ASMIsHygonCpuEx(uint32_t uEBX, uint32_t uECX, uint32_t uEDX)
 {
-    return uEBX == UINT32_C(0x6f677948)
-        && uECX == UINT32_C(0x656e6975)
-        && uEDX == UINT32_C(0x6e65476e);
+    /* 'HygonGenuine' */
+    return uEBX == UINT32_C(0x6f677948)     /* Hygo */
+        && uECX == UINT32_C(0x656e6975)     /* uine */
+        && uEDX == UINT32_C(0x6e65476e);    /* nGen */
 }