Changeset 81716 in vbox

Timestamp:

Nov 6, 2019 4:17:57 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

134479

Message:

EFI/Firmware/VBoxPrintHex.c: Use RShiftU64() instead of >> to avoid unresolved symbol errors when compiling with optimizations turned of for x86

File:

• trunk/src/VBox/Devices/EFI/Firmware/VBoxPkg/Library/VBoxDebugLib/VBoxPrintHex.c (modified) (2 diffs)

trunk/src/VBox/Devices/EFI/Firmware/VBoxPkg/Library/VBoxDebugLib/VBoxPrintHex.c

@@ -30 +30 @@
 *   Header Files                                                                                                                 *
 *********************************************************************************************************************************/
+#include <Library/BaseLib.h>
+
 #include "VBoxDebugLib.h"
 #include "DevEFI.h"
@@ -59 +61 @@
     {
         case 8:
-            vboxPrintHexChar(s_szHex[(uValue >> 60) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 56) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 52) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 48) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 44) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 40) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 36) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 32) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 60) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 56) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 52) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 48) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 44) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 40) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 36) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 32) & 0xf]);
         case 4:
-            vboxPrintHexChar(s_szHex[(uValue >> 28) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 24) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 20) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >> 16) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 28) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 24) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 20) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 16) & 0xf]);
         case 2:
-            vboxPrintHexChar(s_szHex[(uValue >> 12) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue >>  8) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue, 12) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue,  8) & 0xf]);
         case 1:
-            vboxPrintHexChar(s_szHex[(uValue >>  4) & 0xf]);
-            vboxPrintHexChar(s_szHex[(uValue      ) & 0xf]);
+            vboxPrintHexChar(s_szHex[RShiftU64(uValue,  4) & 0xf]);
+            vboxPrintHexChar(s_szHex[         (uValue    ) & 0xf]);
             break;
     }