Changeset 81949 in vbox

Timestamp:

Nov 18, 2019 4:41:06 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

134746

Message:

DevIoApic: indexing paranoia. bugref:9218

File:

• trunk/src/VBox/Devices/PC/DevIoApic.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevIoApic.cpp

@@ -397 +397 @@
  * @param   pThis       The shared I/O APIC device state.
  * @param   pThisCC     The I/O APIC device state for the current context.
- * @param   idxRte      The index of the RTE.
+ * @param   idxRte      The index of the RTE (validated).
  *
  * @remarks It is the responsibility of the caller to verify that an interrupt is
@@ -1058 +1058 @@
     pHlp->pfnPrintf(pHlp, "  idx dst_mode dst_addr mask irr trigger rirr polar dlvr_st dlvr_mode vector\n");
 
-    for (uint8_t idxRte = 0; idxRte <= pThis->u8MaxRte; idxRte++)
+    uint8_t const idxMaxRte = RT_MIN(pThis->u8MaxRte, RT_ELEMENTS(pThis->au64RedirTable) - 1);
+    for (uint8_t idxRte = 0; idxRte <= idxMaxRte; idxRte++)
     {
         static const char * const s_apszDeliveryModes[] =