Changeset 82037 in vbox for trunk/src/VBox/VMM

Timestamp:

Nov 20, 2019 4:57:29 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

134841

Message:

APIC: Remove unused critical section APICCPU::TimerCritSect. The code seems to be using whatever is associated with APICCPU::hTimer. TimerCritSect wasn't even initialized bugref:9218

Location:

trunk/src/VBox/VMM

Files:

• include/APICInternal.h (modified) (2 diffs)
• testcase/tstVMStruct.h (modified) (1 diff)

trunk/src/VBox/VMM/include/APICInternal.h

@@ -1288 +1288 @@
     /** The timer. */
     TMTIMERHANDLE               hTimer;
-    /** The time stamp when the timer was initialized. */
+    /** The time stamp when the timer was initialized.
+     * @note Access protected by the timer critsect.  */
     uint64_t                    u64TimerInitial;
     /** Cache of timer initial count of the frequency hint to TM. */
@@ -1294 +1295 @@
     /** Cache of timer shift of the frequency hint to TM. */
     uint32_t                    uHintedTimerShift;
-    /** The timer critical sect protecting @a u64TimerInitial  */
-    PDMCRITSECT                 TimerCritSect;
     /** The timer description. */
-    char                        szTimerDesc[32];
+    char                        szTimerDesc[16];
     /** @} */
 

trunk/src/VBox/VMM/testcase/tstVMStruct.h

@@ -1407 +1407 @@
     GEN_CHECK_OFF(APICCPU, ApicPibLevel);
     GEN_CHECK_OFF(APICCPU, hTimer);
-    GEN_CHECK_OFF(APICCPU, TimerCritSect);
 
     GEN_CHECK_SIZE(VM);