Changeset 82227 in vbox

Timestamp:

Nov 26, 2019 6:35:15 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135042

Message:

VBox/Debugger: Do not delete debugger windows on close ourselves, we have Qt to do that.

Location:

trunk/src/VBox/Debugger

Files:

• VBoxDbgConsole.cpp (modified) (2 diffs)
• VBoxDbgStatsQt.cpp (modified) (2 diffs)

trunk/src/VBox/Debugger/VBoxDbgConsole.cpp

@@ -490 +490 @@
     m_fTerminate(false), m_fThreadTerminated(false)
 {
+    /* Delete dialog on close: */
+    setAttribute(Qt::WA_DeleteOnClose);
+
     /*
      * Create the output text box.
@@ -994 +997 @@
 {
     if (m_fThreadTerminated)
-    {
         a_pCloseEvt->accept();
-        delete this;
-    }
 }
 

trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp

@@ -3043 +3043 @@
     , m_PatStr(pszPat), m_pPatCB(NULL), m_uRefreshRate(0), m_pTimer(NULL), m_pView(NULL)
 {
+    /* Delete dialog on close: */
+    setAttribute(Qt::WA_DeleteOnClose);
+
     /*
      * On top, a horizontal box with the pattern field, buttons and refresh interval.
@@ -3149 +3152 @@
 {
     a_pCloseEvt->accept();
-    delete this; /** @todo This is wrong! We get more events after this one and end up using memory after freeing it in vPolishSizeAndPos().  (Qt3 holdover?) */
 }