Changeset 82235 in vbox

Timestamp:

Nov 27, 2019 1:01:20 AM (5 years ago)

Author:

vboxsync

Message:

DevSB16: Build fix and some related cleanups (fewer paranoid AssertPtrReturn stuff and unused parameter warnings shows up). bugref:9218

File:

• trunk/src/VBox/Devices/Audio/DevSB16.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Audio/DevSB16.cpp

@@ -1758 +1758 @@
 
 /**
- * Creates a PDM audio stream for a specific driver.
+ * Creates the output PDM audio stream for a specific driver.
  *
  * @returns IPRT status code.
@@ -1793 +1793 @@
 
 /**
- * Destroys a PDM audio stream of a specific driver.
+ * Destroys the output PDM audio stream of a specific driver.
  *
- * @param   pThis               SB16 state.
  * @param   pDrv                Driver stream to destroy PDM stream for.
  */
-static void sb16DestroyDrvStream(PSB16STATE pThis, PSB16DRIVER pDrv)
-{
-    AssertPtr(pThis);
+static void sb16DestroyDrvStreamOut(PSB16DRIVER pDrv)
+{
     AssertPtr(pDrv);
 
@@ -1907 +1905 @@
     RTListForEach(&pThis->lstDrv, pDrv, SB16DRIVER, Node)
     {
-        sb16DestroyDrvStream(pThis, pDrv);
+        sb16DestroyDrvStreamOut(pDrv);
     }
 
@@ -2212 +2210 @@
  *
  * @returns VBox status code.
- * @param   pThis       SB16 state.
  * @param   pDrv        Driver to detach device from.
- * @param   fFlags      Flags, combination of the PDMDEVATT_FLAGS_* \#defines.
- */
-static int sb16DetachInternal(PSB16STATE pThis, PSB16DRIVER pDrv, uint32_t fFlags)
-{
-    RT_NOREF(fFlags);
-
-    sb16DestroyDrvStream(pThis, pDrv);
-
+ */
+static int sb16DetachInternal(PSB16DRIVER pDrv)
+{
+    sb16DestroyDrvStreamOut(pDrv);
     RTListNodeRemove(&pDrv->Node);
-
-    LogFunc(("uLUN=%u, fFlags=0x%x\n", pDrv->uLUN, fFlags));
+    LogFunc(("uLUN=%u\n", pDrv->uLUN));
     return VINF_SUCCESS;
 }
@@ -2259 +2251 @@
         if (pDrv->uLUN == iLUN)
         {
-            int rc2 = sb16DetachInternal(pThis, pDrv, fFlags);
+            int rc2 = sb16DetachInternal(pDrv);
             if (RT_SUCCESS(rc2))
             {
@@ -2333 +2325 @@
     RTListForEach(&pThis->lstDrv, pDrv, SB16DRIVER, Node)
     {
-        sb16DestroyDrvStream(pThis, pDrv);
+        sb16DestroyDrvStreamOut(pDrv);
     }
 }