Changeset 82247 in vbox

Timestamp:

Nov 27, 2019 3:54:40 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135064

Message:

FE/Qt: bugref:9611: UIMachineSettingsStorage: Check whether storage bus is supported before adding related types to bus selection combo.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -1460 +1460 @@
 void ControllerItem::updateBusInfo()
 {
+    /* Clear the buses initially: */
     m_buses.clear();
 
-    switch (m_enmBus)
-    {
-        case KStorageBus_IDE:
-        case KStorageBus_SATA:
-        case KStorageBus_SCSI:
-        case KStorageBus_SAS:
-        case KStorageBus_USB:
-        case KStorageBus_PCIe:
-        case KStorageBus_VirtioSCSI:
-        {
-            m_buses << KStorageBus_IDE << KStorageBus_SATA << KStorageBus_SCSI << KStorageBus_SAS
-                    << KStorageBus_USB << KStorageBus_PCIe << KStorageBus_VirtioSCSI;
-            m_buses.removeAll(m_enmBus);
-        }
-        RT_FALL_THRU();
-        default:
-        {
-            m_buses.prepend(m_enmBus);
-            break;
-        }
-    }
+    /* Load currently supported storage buses: */
+    CSystemProperties comProperties = uiCommon().virtualBox().GetSystemProperties();
+    const QVector<KStorageBus> supportedBuses = comProperties.GetSupportedStorageBuses();
+
+    /* If current bus is NOT KStorageBus_Floppy: */
+    if (m_enmBus != KStorageBus_Floppy)
+    {
+        /* We update the list with all supported buses
+         * and remove the current one from that list. */
+        m_buses << supportedBuses.toList();
+        m_buses.removeAll(m_enmBus);
+    }
+
+    /* And prepend current bus finally: */
+    m_buses.prepend(m_enmBus);
 }