Changeset 82252 in vbox for trunk/src/VBox/Devices/Audio/DevHDACommon.cpp

Timestamp:

Nov 27, 2019 9:31:53 PM (5 years ago)

Author:

vboxsync

Message:

vmm/pdmaudioifs.h: Style, docs and other nits. First, it's always _FLAGS_ never _FLAG_. Second, enums generally should start with _INVALID = 0 to ensure we don't mistake zero-initialized memory for valid data. Struct member names shall be indented on a tab (+4) boundrary. PDM is part of the VMM, so it follows the VMM coding guidelines strictly. Skip the 'Structure for keeping a ... around' fluff, the first sentence of a structure (or anything else for that matter) documentation shall be brief and to the point. It is automatically turned into a @brief. Furthermore, additional text should be a separate paragraph as it provides details the reader doesn't necessarily need to read. bugref:9218

File:

• trunk/src/VBox/Devices/Audio/DevHDACommon.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDACommon.cpp

@@ -547 +547 @@
         RT_BZERO(pProps, sizeof(PDMAUDIOPCMPROPS));
 
-        pProps->cBytes    = cBytes;
+        pProps->cbSample  = cBytes;
         pProps->fSigned   = true;
         pProps->cChannels = (u16SDFMT & 0xf) + 1;
         pProps->uHz       = u32Hz * u32HzMult / u32HzDiv;
-        pProps->cShift    = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(pProps->cBytes, pProps->cChannels);
+        pProps->cShift    = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(pProps->cbSample, pProps->cChannels);
     }