Changeset 82402 in vbox for trunk/src

Timestamp:

Dec 4, 2019 11:50:36 PM (5 years ago)

Author:

vboxsync

Message:

DevHDA: Removed unnecessary input masking in hdaRegWriteSDCTL and instead make hdaMmioWrite do the requested masking according to the register size (I suspect the masking was added to avoid assertion in the 24-bit register writer). Guest does not write junk in the top 8-bits, they write the SDSTS register, only hdaMmioWrite confused us here. bugref:9218

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1221 +1221 @@
 
     /*
-     * Some guests write too much (that is, 32-bit with the top 8 bit being junk)
-     * instead of 24-bit required for SDCTL. So just mask this here to be safe.
-     */
-    u32Value &= 0x00ffffff;
-
-    /*
      * Extract the stream tag the guest wants to use for this specific
      * stream descriptor (SDn). This only can happen if the stream is in a non-running
@@ -3333 +3327 @@
                 uint32_t uLogOldVal = pThis->au32Regs[idxRegMem];
 # endif
-                rc = hdaWriteReg(pDevIns, pThis, idxRegDsc, u64Value, "*");
+                rc = hdaWriteReg(pDevIns, pThis, idxRegDsc, u64Value & g_afMasks[cbReg], "*");
                 Log4Func(("\t%#x -> %#x\n", uLogOldVal, pThis->au32Regs[idxRegMem]));
             }