Changeset 82419 in vbox for trunk/src/VBox

Timestamp:

Dec 5, 2019 1:39:50 PM (5 years ago)

Author:

vboxsync

Message:

DevHDA: Disabled the HDASTREAMPERIOD::CritSect as it isn't currently needed (lock/unlock functions are no-ops). bugref:9218

Location:

trunk/src/VBox/Devices/Audio

Files:

• HDAStreamPeriod.cpp (modified) (4 diffs)
• HDAStreamPeriod.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.cpp

@@ -52 +52 @@
     Assert(!(pPeriod->fStatus & HDASTREAMPERIOD_F_VALID));
 
+# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
     int rc = RTCritSectInit(&pPeriod->CritSect);
     AssertRCReturnStmt(rc, pPeriod->fStatus = 0, rc);
+# endif
     pPeriod->fStatus = HDASTREAMPERIOD_F_VALID;
 
@@ -68 +70 @@
     if (pPeriod->fStatus & HDASTREAMPERIOD_F_VALID)
     {
+# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
         RTCritSectDelete(&pPeriod->CritSect);
-
+# endif
         pPeriod->fStatus = HDASTREAMPERIOD_F_NONE;
     }
@@ -229 +232 @@
 int hdaR3StreamPeriodLock(PHDASTREAMPERIOD pPeriod)
 {
+# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
     int rc = RTCritSectEnter(&pPeriod->CritSect);
     AssertRC(rc);
     return rc;
+# else
+    RT_NOREF(pPeriod);
+    return VINF_SUCCESS;
+# endif
 }
 
@@ -241 +249 @@
 void hdaR3StreamPeriodUnlock(PHDASTREAMPERIOD pPeriod)
 {
+# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
     int rc2 = RTCritSectLeave(&pPeriod->CritSect);
     AssertRC(rc2);
+# else
+    RT_NOREF(pPeriod);
+# endif
 }
 

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.h

@@ -54 +54 @@
 typedef struct HDASTREAMPERIOD
 {
+#ifdef HDA_STREAM_PERIOD_WITH_LOCKING
     /** Critical section for serializing access.
      * @todo r=bird: This is not needed.  The stream lock is held the two places
      *       this critsect is entered. */
     RTCRITSECT              CritSect;
+#endif
     /** Associated HDA stream descriptor (SD) number. */
     uint8_t                 u8SD;