Changeset 82422 in vbox for trunk/src/VBox/Main

Timestamp:

Dec 5, 2019 3:59:34 PM (5 years ago)

Author:

vboxsync

Message:

Main/Recording: Cleanup; greatly reduced the include maze.

Location:

trunk/src/VBox/Main

Files:

• include/EBMLWriter.h (modified) (1 diff)
• include/Recording.h (modified) (1 diff)
• include/RecordingInternals.h (modified) (1 diff)
• include/RecordingStream.h (modified) (1 diff)
• include/RecordingUtils.h (modified) (1 diff)
• include/WebMWriter.h (modified) (1 diff)
• src-client/RecordingStream.cpp (modified) (2 diffs)
• src-client/WebMWriter.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/EBMLWriter.h

@@ -22 +22 @@
 #endif
 
-#include <iprt/file.h>
-#include <VBox/com/string.h>
-
 #include <stack>
 
-#include <iprt/cdefs.h>
+#include <iprt/critsect.h>
 #include <iprt/file.h>
 

trunk/src/VBox/Main/include/Recording.h

@@ -22 +22 @@
 #endif
 
-#include <VBox/com/array.h>
-#include <VBox/com/string.h>
-#include <VBox/com/VirtualBox.h>
+using namespace com;
+
+#include <VBox/err.h>
 #include <VBox/settings.h>
 
-using namespace com;
-
-#include "RecordingInternals.h"
 #include "RecordingStream.h"
 

trunk/src/VBox/Main/include/RecordingInternals.h

@@ -22 +22 @@
 #endif
 
-#include <iprt/assert.h>
+#include <list>
+
 #include <iprt/types.h> /* drag in stdint.h before vpx does it. */
-#include <list>
 
 #ifdef VBOX_WITH_LIBVPX

trunk/src/VBox/Main/include/RecordingStream.h

@@ -26 +26 @@
 
 #include <iprt/critsect.h>
-
-#include <VBox/settings.h>
 
 #include "RecordingInternals.h"

trunk/src/VBox/Main/include/RecordingUtils.h

@@ -21 +21 @@
 # pragma once
 #endif
-
-#include <iprt/asm.h>
-#include <iprt/assert.h>
-#include <iprt/critsect.h>
-#include <iprt/path.h>
-#include <iprt/semaphore.h>
-#include <iprt/thread.h>
-#include <iprt/time.h>
 
 

trunk/src/VBox/Main/include/WebMWriter.h

@@ -23 +23 @@
 
 #include "EBMLWriter.h"
+#include "EBML_MKV.h"
 
 #include <queue>

trunk/src/VBox/Main/src-client/RecordingStream.cpp

@@ -22 +22 @@
 #include "LoggingNew.h"
 
-#include <stdexcept>
-
-#include <iprt/asm.h>
-#include <iprt/assert.h>
-#include <iprt/critsect.h>
-#include <iprt/file.h>
 #include <iprt/path.h>
-#include <iprt/semaphore.h>
-#include <iprt/thread.h>
-#include <iprt/time.h>
-
-#include <VBox/err.h>
-#include <VBox/com/VirtualBox.h>
 
 #include "Recording.h"
-#include "RecordingStream.h"
 #include "RecordingUtils.h"
 #include "WebMWriter.h"
 
+
+#ifdef VBOX_RECORDING_DUMP
+#pragma pack(push)
+#pragma pack(1)
+typedef struct
+{
+    uint16_t uMagic;
+    uint32_t uSize;
+    uint16_t uReserved1;
+    uint16_t uReserved2;
+    uint32_t uOffBits;
+} RECORDINGBMPHDR, *PRECORDINGBMPHDR;
+AssertCompileSize(RECORDINGBMPHDR, 14);
+
+typedef struct
+{
+    uint32_t uSize;
+    uint32_t uWidth;
+    uint32_t uHeight;
+    uint16_t uPlanes;
+    uint16_t uBitCount;
+    uint32_t uCompression;
+    uint32_t uSizeImage;
+    uint32_t uXPelsPerMeter;
+    uint32_t uYPelsPerMeter;
+    uint32_t uClrUsed;
+    uint32_t uClrImportant;
+} RECORDINGBMPDIBHDR, *PRECORDINGBMPDIBHDR;
+AssertCompileSize(RECORDINGBMPDIBHDR, 40);
+
+#pragma pack(pop)
+#endif /* VBOX_RECORDING_DUMP */
 
 RecordingStream::RecordingStream(RecordingContext *a_pCtx)
@@ -652 +671 @@
         RT_ZERO(bmpDIBHdr);
 
-        bmpHdr.u16Magic   = 0x4d42; /* Magic */
-        bmpHdr.u32Size    = (uint32_t)(sizeof(RECORDINGBMPHDR) + sizeof(RECORDINGBMPDIBHDR) + (w * h * uBytesPerPixel));
-        bmpHdr.u32OffBits = (uint32_t)(sizeof(RECORDINGBMPHDR) + sizeof(RECORDINGBMPDIBHDR));
-
-        bmpDIBHdr.u32Size          = sizeof(RECORDINGBMPDIBHDR);
-        bmpDIBHdr.u32Width         = w;
-        bmpDIBHdr.u32Height        = h;
-        bmpDIBHdr.u16Planes        = 1;
-        bmpDIBHdr.u16BitCount      = uBPP;
-        bmpDIBHdr.u32XPelsPerMeter = 5000;
-        bmpDIBHdr.u32YPelsPerMeter = 5000;
+        bmpHdr.uMagic   = 0x4d42; /* Magic */
+        bmpHdr.uSize    = (uint32_t)(sizeof(RECORDINGBMPHDR) + sizeof(RECORDINGBMPDIBHDR) + (w * h * uBytesPerPixel));
+        bmpHdr.uOffBits = (uint32_t)(sizeof(RECORDINGBMPHDR) + sizeof(RECORDINGBMPDIBHDR));
+
+        bmpDIBHdr.uSize          = sizeof(RECORDINGBMPDIBHDR);
+        bmpDIBHdr.uWidth         = w;
+        bmpDIBHdr.uHeight        = h;
+        bmpDIBHdr.uPlanes        = 1;
+        bmpDIBHdr.uBitCount      = uBPP;
+        bmpDIBHdr.uXPelsPerMeter = 5000;
+        bmpDIBHdr.uYPelsPerMeter = 5000;
 
         char szFileName[RTPATH_MAX];

trunk/src/VBox/Main/src-client/WebMWriter.cpp

@@ -25 +25 @@
 #include "LoggingNew.h"
 
-#include <iprt/cdefs.h>
-#include <iprt/critsect.h>
-#include <iprt/errcore.h>
-#include <iprt/file.h>
 #include <iprt/buildconfig.h>
-
-#include <VBox/log.h>
 #include <VBox/version.h>
 
 #include "WebMWriter.h"
-#include "EBML_MKV.h"