Changeset 82430 in vbox for trunk/src/VBox

Timestamp:

Dec 5, 2019 4:49:10 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9390: UIGraphicsControllerEditor: Proactively caching value to be able to operate over it even if it's not around supported values.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/widgets

Files:

• UIGraphicsControllerEditor.cpp (modified) (3 diffs)
• UIGraphicsControllerEditor.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIGraphicsControllerEditor.cpp

@@ -30 +30 @@
     : QIWithRetranslateUI<QWidget>(pParent)
     , m_fWithLabel(fWithLabel)
+    , m_enmValue(KGraphicsControllerType_Max)
     , m_pLabel(0)
     , m_pCombo(0)
@@ -40 +41 @@
     if (m_pCombo)
     {
-        int iIndex = m_pCombo->findData(QVariant::fromValue(enmValue));
+        /* Update cached value: */
+        m_enmValue = enmValue;
+
+        /* Look for proper index to choose: */
+        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
         if (iIndex != -1)
             m_pCombo->setCurrentIndex(iIndex);
@@ -48 +53 @@
 KGraphicsControllerType UIGraphicsControllerEditor::value() const
 {
-    return m_pCombo ? m_pCombo->itemData(m_pCombo->currentIndex()).value<KGraphicsControllerType>() : KGraphicsControllerType_Null;
+    return m_pCombo ? m_pCombo->currentData().value<KGraphicsControllerType>() : m_enmValue;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIGraphicsControllerEditor.h

@@ -77 +77 @@
     bool  m_fWithLabel;
 
+    /** Holds the value to be selected. */
+    KGraphicsControllerType  m_enmValue;
+
     /** Holds the label instance. */
     QLabel     *m_pLabel;