Changeset 82452 in vbox

Timestamp:

Dec 6, 2019 12:46:40 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135302

Message:

DevHDA: Put debug path on the heap rather than always grabbing ~4KB of state data for it. doxygen and scm fixes. bugref:9218

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevHDA.cpp (modified) (3 diffs)
• DevHDA.h (modified) (1 diff)
• HDACodec.h (modified) (4 diffs)
• HDAStream.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -4298 +4298 @@
  * @param   pDevIns     The device instance.
  * @param   pThis       The shared HDA device state.
- * @param   pThisR3     The ring-3 HDA device state.
+ * @param   pThisCC     The ring-3 HDA device state.
  * @param   uLUN        The logical unit which is being detached.
  * @param   fFlags      Flags, combination of the PDMDEVATT_FLAGS_* \#defines.
@@ -4648 +4648 @@
                                 N_("HDA configuration error: failed to read debugging enabled flag as boolean"));
 
-    rc = pHlp->pfnCFGMQueryStringDef(pCfg, "DebugPathOut", pThisCC->Dbg.szOutPath, sizeof(pThisCC->Dbg.szOutPath),
-                                     VBOX_AUDIO_DEBUG_DUMP_PCM_DATA_PATH);
+    rc = pHlp->pfnCFGMQueryStringAllocDef(pCfg, "DebugPathOut", &pThisCC->Dbg.pszOutPath, VBOX_AUDIO_DEBUG_DUMP_PCM_DATA_PATH);
     if (RT_FAILURE(rc))
         return PDMDEV_SET_ERROR(pDevIns, rc,
@@ -4655 +4654 @@
 
     if (pThisCC->Dbg.fEnabled)
-        LogRel2(("HDA: Debug output will be saved to '%s'\n", pThisCC->Dbg.szOutPath));
+        LogRel2(("HDA: Debug output will be saved to '%s'\n", pThisCC->Dbg.pszOutPath));
 
     /*

trunk/src/VBox/Devices/Audio/DevHDA.h

@@ -246 +246 @@
         /** Path where to dump the debug output to.
          *  Defaults to VBOX_AUDIO_DEBUG_DUMP_PCM_DATA_PATH. */
-        char                    szOutPath[RTPATH_MAX];
+        R3PTRTYPE(char *)       pszOutPath;
     } Dbg;
 } HDASTATER3;

trunk/src/VBox/Devices/Audio/HDACodec.h

@@ -124 +124 @@
      *
      * @return  VBox status code.
-     * @param   pThisCC             The ring-3 HDA device state.
+     * @param   pDevIns             The device instance.
      * @param   enmMixerCtl         Mixer control to assign new stream to.
      * @param   pCfg                Stream configuration for the new stream.
@@ -133 +133 @@
      *
      * @return  VBox status code.
-     * @param   pThisCC             The ring-3 HDA device state.
+     * @param   pDevIns             The device instance.
      * @param   enmMixerCtl         Mixer control to remove.
      */
@@ -142 +142 @@
      *
      * @return  VBox status code.
-     * @param   pThisCC             The ring-3 HDA device state.
+     * @param   pDevIns             The device instance.
      * @param   enmMixerCtl         Mixer control to set SD stream number and channel for.
      * @param   uSD                 SD stream number (number + 1) to set. Set to 0 for unassign.
@@ -152 +152 @@
      *
      * @return  IPRT status code.
-     * @param   pThisCC             The ring-3 HDA device state.
+     * @param   pDevIns             The device instance.
      * @param   enmMixerCtl         Mixer control to set volume for.
      * @param   pVol                Pointer to volume data to set.

trunk/src/VBox/Devices/Audio/HDAStream.cpp

@@ -35 +35 @@
 #include "HDAStream.h"
 
-
 #ifdef IN_RING3 /* whole file */
+
 
 /*********************************************************************************************************************************
@@ -103 +103 @@
             RTStrPrintf(szFile, sizeof(szFile), "hdaStreamReadSD%RU8", uSD);
 
-        int rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.szOutPath, szFile,
+        int rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.pszOutPath, szFile,
                                          0 /* uInst */, PDMAUDIOFILETYPE_WAV, PDMAUDIOFILENAME_FLAGS_NONE);
         AssertRC(rc2);
@@ -116 +116 @@
             RTStrPrintf(szFile, sizeof(szFile), "hdaDMARawReadSD%RU8", uSD);
 
-        rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.szOutPath, szFile,
+        rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.pszOutPath, szFile,
                                      0 /* uInst */, PDMAUDIOFILETYPE_WAV, PDMAUDIOFILENAME_FLAGS_NONE);
         AssertRC(rc2);
@@ -129 +129 @@
             RTStrPrintf(szFile, sizeof(szFile), "hdaDMAReadMappedSD%RU8", uSD);
 
-        rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.szOutPath, szFile,
+        rc2 = DrvAudioHlpFileNameGet(szPath, sizeof(szPath), pThisCC->Dbg.pszOutPath, szFile,
                                      0 /* uInst */, PDMAUDIOFILETYPE_WAV, PDMAUDIOFILENAME_FLAGS_NONE);
         AssertRC(rc2);