Changeset 82474 in vbox for trunk/src/VBox

Timestamp:

Dec 6, 2019 7:55:06 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: Few NLS related todos around whole the GUI.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• converter/UIConverterBackendCOM.cpp (modified) (4 diffs)
• globals/UICustomFileSystemModel.cpp (modified) (1 diff)
• guestctrl/UIFileManagerTable.cpp (modified) (2 diffs)
• runtime/information/UIInformationRuntime.cpp (modified) (1 diff)
• runtime/information/UIVMInformationDialog.cpp (modified) (1 diff)
• softkeyboard/UISoftKeyboard.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/converter/UIConverterBackendCOM.cpp

@@ -702 +702 @@
 }
 
+/// @todo Internal strings never being translated.
+///       If that is user-visible string then it is toString() and then each word should be
+///       translated separately (i.e. "TimedOutKilled" should be "Timed Out Killed").
+///       If that is purely internal thing used to tag something or save value to extra-data
+///       then this is toInternalString() indeed but no QApplication::translate should be used.
 template<> QString toInternalString(const KGuestSessionStatus &enmStatus)
 {
@@ -720 +725 @@
 }
 
+/// @todo Internal strings never being translated.
+///       If that is user-visible string then it is fromString() and then each word should be
+///       translated separately (i.e. "TimedOutKilled" should be "Timed Out Killed").
+///       If that is purely internal thing used to tag something or save value to extra-data
+///       then this is fromInternalString() indeed but no QApplication::translate should be used.
 template<> KGuestSessionStatus fromInternalString<KGuestSessionStatus>(const QString &strStatus)
 {
@@ -739 +749 @@
 }
 
+/// @todo Internal strings never being translated.
+///       If that is user-visible string then it is toString() and then each word should be
+///       translated separately (i.e. "TimedOutKilled" should be "Timed Out Killed").
+///       If that is purely internal thing used to tag something or save value to extra-data
+///       then this is toInternalString() indeed but no QApplication::translate should be used.
 template<> QString toInternalString(const KProcessStatus &enmStatus)
 {
@@ -760 +775 @@
 }
 
+/// @todo Internal strings never being translated.
+///       If that is user-visible string then it is fromString() and then each word should be
+///       translated separately (i.e. "TimedOutKilled" should be "Timed Out Killed").
+///       If that is purely internal thing used to tag something or save value to extra-data
+///       then this is fromInternalString() indeed but no QApplication::translate should be used.
 template<> KProcessStatus fromInternalString<KProcessStatus>(const QString &strStatus)
 {

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICustomFileSystemModel.cpp

@@ -611 +611 @@
     m_pRootItem->setData(UICustomFileSystemModel::tr("Owner"), UICustomFileSystemModelColumn_Owner);
     m_pRootItem->setData(UICustomFileSystemModel::tr("Permissions"), UICustomFileSystemModelColumn_Permissions);
+    /// @todo Is this guy really user-readable. If that is so then each word should
+    ///       be translated separately (i.e. "LocalPath" should be "Local Path").
     m_pRootItem->setData(UICustomFileSystemModel::tr("LocalPath"), UICustomFileSystemModelColumn_LocalPath);
     m_pRootItem->setData(UICustomFileSystemModel::tr("Path"), UICustomFileSystemModelColumn_Path);

trunk/src/VBox/Frontends/VirtualBox/src/guestctrl/UIFileManagerTable.cpp

@@ -1109 +1109 @@
         return;
 
+    /// @todo Is this guy really user-readable. If that is so then each word should
+    ///       be translated separately (i.e. "NewDirectory" should be "New Directory").
     QString newDirectoryName(UICustomFileSystemModel::tr("NewDirectory"));
 
@@ -1296 +1298 @@
         pRootItem->setData(UICustomFileSystemModel::tr("Permissions"), UICustomFileSystemModelColumn_Permissions);
     }
+    /// @todo Using \n breaks between words of the same sentence isn't allowed. This isn't easily translateable to other
+    ///       languages.  Moreover, using of \n isn't allowed at all.  This isn't exactly a cross-platform identifier.
+    ///       You can use only <br> between sentenses of the same paragraph. Most of Qt text is HTML by definition, so
+    ///       it does support <br> tags.
     if (m_pWarningLabel)
         m_pWarningLabel->setText(UIFileManager::tr("No Guest Session\nPlease use the Session Panel to start \na guest session"));

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIInformationRuntime.cpp

@@ -177 +177 @@
 void UIRuntimeInfoWidget::retranslateUi()
 {
+    /// @todo These NLS tags have to be reworked the following way:
+    ///       Each place which uses plural/gender-neutral verbs like Active, Inactive, Not Available, not set and Not Detected
+    ///       should use it directly like tr("Active", "Guest Additions") to make sure translator knows for sure whether this
+    ///       verb is related to single or plural form and male/female/neutral sex. There are languages different than English
+    ///       which sounds absolutely stupid if you ignore those rules while sequencing nouns and corresponding verbs.
     m_strTableTitle = QApplication::translate("UIVMInformationDialog", "Runtime Attributes");
     m_strScreenResolutionLabel = QApplication::translate("UIVMInformationDialog", "Screen Resolution");

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIVMInformationDialog.cpp

@@ -113 +113 @@
     m_pTabWidget->setTabText(1, tr("&Runtime Information"));
     m_pTabWidget->setTabText(2, tr("Performance &Monitor"));
+    /// @todo Shouldn't that be just "&Guest Control"?
     m_pTabWidget->setTabText(3, tr("Guest Control &Session Information"));
 }

trunk/src/VBox/Frontends/VirtualBox/src/softkeyboard/UISoftKeyboard.cpp

@@ -2448 +2448 @@
     dialog.setWindowTitle(UISoftKeyboard::tr("Provide a file name"));
     dialog.setTextValue(currentLayout.name());
+    /// @todo Using \n breaks between words of the same sentence isn't allowed. This isn't easily translateable to other
+    ///       languages.  Moreover, using of \n isn't allowed at all.  This isn't exactly a cross-platform identifier.
+    ///       You can use only <br> between sentenses of the same paragraph. Most of Qt text is HTML by definition, so
+    ///       it does support <br> tags.
     dialog.setLabelText(QString("%1 %2").arg(UISoftKeyboard::tr("The file will be saved under:\n")).arg(strHomeFolder));
     if (dialog.exec() == QDialog::Rejected)