Changeset 82498 in vbox for trunk/src

Timestamp:

Dec 8, 2019 12:26:36 AM (5 years ago)

Author:

vboxsync

Message:

todos. bugref:9437

Location:

trunk/src/VBox

Files:

• GuestHost/SharedClipboard/clipboard-common.cpp (modified) (2 diffs)
• HostServices/SharedClipboard/VBoxSharedClipboardSvc-win.cpp (modified) (1 diff)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp

@@ -258 +258 @@
 static void shclEventPayloadDetachInternal(PSHCLEVENT pEvent)
 {
+    /** @todo r=bird: This should return pPayload.  It should also not need
+     *        assert the validity of pEvent in non-strict builds, given that this
+     *        is an static + internal function, that's a complete waste of time. */
     AssertPtrReturnVoid(pEvent);
 
@@ -426 +429 @@
 void ShClEventPayloadDetach(PSHCLEVENTSOURCE pSource, SHCLEVENTID uID)
 {
+    /** @todo r=bird: This API is not needed, it either is a no-op as it
+     *        replicates work done by ShClEventWait or it leaks the payload as
+     *        ShClEventWait is the only way to get it as far as I can tell. */
+
     AssertPtrReturnVoid(pSource);
 

trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-win.cpp

@@ -197 +197 @@
             /* Detach the payload, as the caller then will own the data. */
             ShClEventPayloadDetach(&pCtx->pClient->Events, uEvent);
+            /**
+             * @todo r=bird: The payload has already been detached,
+             * ShClEventPayloadDetach and ShClEventWait does the exact same
+             * thing, except for the extra waiting in the latter.
+             */
         }