Changeset 82521 in vbox for trunk/src/VBox/Devices/EFI

Timestamp:

Dec 9, 2019 3:26:21 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135374

Message:

EFI/Firmware/VBoxFsDxe: Fix a read beyond the of buffer due to the source buffer being shorter than kHFSMaxVolumeNameChars (very very lazy fix)

File:

• trunk/src/VBox/Devices/EFI/Firmware/VBoxPkg/VBoxFsDxe/fsw_hfs.c (modified) (1 diff)

trunk/src/VBox/Devices/EFI/Firmware/VBoxPkg/VBoxFsDxe/fsw_hfs.c

@@ -282 +282 @@
         s.type = FSW_STRING_TYPE_ISO88591;
         s.size = s.len = kHFSMaxVolumeNameChars;
-        s.data = "HFS+ volume";
+        s.data = "HFS+ volume\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"; /* Otherwise buffer overflow reading beyond the end of the buffer. */
         status = fsw_strdup_coerce(&vol->g.label, vol->g.host_string_type, &s);
         CHECK(status);