Changeset 82618 in vbox for trunk/src/VBox/Additions/WINNT/Installer

Timestamp:

Dec 18, 2019 2:33:10 PM (5 years ago)

Author:

vboxsync

Message:

Windows Additions/Installer: Added a new testcase for the GuestInstallHelper DLL, to check whether the NSIS-specified API (still) works. Added more code to make the DLL compatible with NSIS v3.x, which in turn should make the file vendor / architecture detection work again [additions build fix], bugref:9529.

Location:

trunk/src/VBox/Additions/WINNT/Installer/InstallHelper/testcase

Files:

• Makefile.kmk (modified) (1 diff)
• tstWinAdditionsInstallHelper.cpp (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/Installer/InstallHelper/testcase/Makefile.kmk

@@ -25 +25 @@
 #
 PROGRAMS.x86 += tstWinAdditionsInstallHelper
-tstWinAdditionsInstallHelper_TEMPLATE = VBOXR3TSTEXE
+tstWinAdditionsInstallHelper_TEMPLATE = VBoxGuestR3Exe
 tstWinAdditionsInstallHelper_SOURCES  = tstWinAdditionsInstallHelper.cpp
 tstWinAdditionsInstallHelper_DEFS     = _WIN32_WINNT=0x0400 WIN32_LEAN_AND_MEAN=1 TESTCASE
-tstWinAdditionsInstallHelper_LIBS     = $(LIB_RUNTIME)
 
 endif # VBOX_WITH_TESTCASES
 
 include $(FILE_KBUILD_SUB_FOOTER)
-

trunk/src/VBox/Additions/WINNT/Installer/InstallHelper/testcase/tstWinAdditionsInstallHelper.cpp

@@ -127 +127 @@
     RTProcGetExecutablePath(szGuestInstallHelperDll, sizeof(szGuestInstallHelperDll));
 
-    /** @todo This ASSUMES that the testcase always is located in the separate "testcase" sub directory
+    /** @todo This ASSUMES that this testcase always is located in the separate "bin/additions" sub directory
      *        and that we currently always repack the Guest Additions stuff in a separate directory.
      *        Might need some more tweaking ... */