Changeset 82669 in vbox for trunk/src/VBox/HostDrivers/VBoxUSB/win

Timestamp:

Jan 8, 2020 11:10:43 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135573

Message:

VBoxUSBMon.sys: Comments, tweaked disabled code.

File:

• trunk/src/VBox/HostDrivers/VBoxUSB/win/mon/VBoxUsbFlt.cpp (modified) (1 diff)

trunk/src/VBox/HostDrivers/VBoxUSB/win/mon/VBoxUsbFlt.cpp

@@ -668 +668 @@
                 }
 
+                /* The CompatibleID the IOCTL gives is not always the same as what the PnP Manager uses
+                 * (thanks, Microsoft). It might look like "USB\DevClass_00&SubClass_00&Prot_00" or like
+                 * "USB\USB30_HUB". In such cases, we must consider the class/subclass/protocol
+                 * information simply unavailable.
+                 */
                 rc = vboxUsbParseCompatibleIDs(HubInfo.CompatibleIds.Buffer, &cls, &sub, &prt);
                 if (!rc)
                 {
-                    /* This *really* should not happen. */
-                    WARN(("Failed to parse Hardware ID"));
-                    break;
+                    /* This is unfortunate but not fatal. */
+                    WARN(("Failed to parse Compatible ID"));
                 }
                 LOG(("Parsed HardwareID from IOCTL: vid=%04X, pid=%04X, rev=%04X, class=%02X, subcls=%02X, prot=%02X", vid, pid, rev, cls, sub, prt));