Changeset 82672 in vbox for trunk/src/VBox/Debugger

Timestamp:

Jan 8, 2020 1:26:57 PM (5 years ago)

Author:

vboxsync

Message:

DBGC: Tying up some loose ends. bugref:9612

File:

• trunk/src/VBox/Debugger/DBGCCmdHlp.cpp (modified) (6 diffs)

trunk/src/VBox/Debugger/DBGCCmdHlp.cpp

@@ -432 +432 @@
 
             case DBGCVAR_TYPE_HC_PHYS:
-            case DBGCVAR_TYPE_HC_FLAT:
             {
                 DBGCVAR Var2;
@@ -438 +437 @@
                 if (RT_SUCCESS(rc))
                 {
-                    /** @todo protect this!!! */
                     memcpy(pvBuffer, Var2.u.pvHCFlat, cb);
-                    rc = 0;
+                    rc = VINF_SUCCESS;
                 }
                 else
@@ -446 +444 @@
                 break;
             }
+
+            case DBGCVAR_TYPE_HC_FLAT:
+                rc = VERR_NOT_SUPPORTED;
+                break;
 
             default:
@@ -572 +574 @@
             return rc;
 
-        case DBGCVAR_TYPE_HC_FLAT:
         case DBGCVAR_TYPE_HC_PHYS:
         {
@@ -598 +599 @@
                     cbChunk = cbWrite;
 
-                /** @todo protect this!!! */
                 memcpy(Var2.u.pvHCFlat, pvBuffer, cbChunk);
 
@@ -614 +614 @@
             return VINF_SUCCESS;
         }
+
+        case DBGCVAR_TYPE_HC_FLAT:
+            return VERR_NOT_SUPPORTED;
 
         default: