Changeset 8277 in vbox for trunk/include

Timestamp:

Apr 22, 2008 11:56:47 AM (17 years ago)

Author:

vboxsync

Message:

indent. put the remarks on the group definition.

File:

• trunk/include/iprt/asm.h (modified) (5 diffs)

trunk/include/iprt/asm.h

@@ -38 +38 @@
  * Defined as 1 if we're using a _MSC_VER 1400.
  * Otherwise defined as 0.
- */
-
-/** @note
- *
- * Some remarks about __volatile__: Without this keyword gcc is allowed to reorder
- * or even optimize assembler instructions away. For instance, in the following code
- * the second rdmsr instruction is optimized away because gcc treats that instruction
- * as deterministic:
- *
- *   @code
- *   static inline uint64_t rdmsr_low(idx)
- *   {
- *     uint32_t low;
- *     __asm__ ("rdmsr" : "=a"(low) : "c"(idx) : "edx");
- *   }
- *   ...
- *   uint32_t msr1 = rdmsr(1);
- *   foo(msr1);
- *   msr1 = rdmsr(1);
- *   bar(msr1);
- *   @endcode
- *
- * The input parameter of rdmsr_low is the same for both calls and therefore gcc will
- * use the result of the first call as input parameter for bar() as well. For rdmsr this
- * is not acceptable as this instruction is _not_ deterministic. This applies to reading
- * machine status information in general.
  */
 
@@ -141 +115 @@
  *          are unordered (note the Uo).
  *
+ * @remarks Some remarks about __volatile__: Without this keyword gcc is allowed to reorder
+ *          or even optimize assembler instructions away. For instance, in the following code
+ *          the second rdmsr instruction is optimized away because gcc treats that instruction
+ *          as deterministic:
+ *
+ *            @code
+ *            static inline uint64_t rdmsr_low(int idx)
+ *            {
+ *              uint32_t low;
+ *              __asm__ ("rdmsr" : "=a"(low) : "c"(idx) : "edx");
+ *            }
+ *            ...
+ *            uint32_t msr1 = rdmsr_low(1);
+ *            foo(msr1);
+ *            msr1 = rdmsr_low(1);
+ *            bar(msr1);
+ *            @endcode
+ *
+ *          The input parameter of rdmsr_low is the same for both calls and therefore gcc will
+ *          use the result of the first call as input parameter for bar() as well. For rdmsr this
+ *          is not acceptable as this instruction is _not_ deterministic. This applies to reading
+ *          machine status information in general.
+ *
  * @{
  */
@@ -1388 +1385 @@
     RTUINT64U u;
 # if RT_INLINE_ASM_GNU_STYLE
-    __asm__ __volatile__ ("rdmsr\n\t"
-             : "=a" (u.s.Lo),
-               "=d" (u.s.Hi)
-             : "c" (uRegister));
+    __asm__ __volatile__("rdmsr\n\t"
+                         : "=a" (u.s.Lo),
+                           "=d" (u.s.Hi)
+                         : "c" (uRegister));
 
 # elif RT_INLINE_ASM_USES_INTRIN
@@ -1462 +1459 @@
 # if RT_INLINE_ASM_GNU_STYLE
     __asm__ __volatile__("rdmsr\n\t"
-             : "=a" (u32)
-             : "c" (uRegister)
-             : "edx");
+                         : "=a" (u32)
+                         : "c" (uRegister)
+                         : "edx");
 
 # elif RT_INLINE_ASM_USES_INTRIN
@@ -1497 +1494 @@
 # if RT_INLINE_ASM_GNU_STYLE
     __asm__ __volatile__("rdmsr\n\t"
-             : "=d" (u32)
-             : "c" (uRegister)
-             : "eax");
+                         : "=d" (u32)
+                         : "c" (uRegister)
+                         : "eax");
 
 # elif RT_INLINE_ASM_USES_INTRIN