Changeset 8279 in vbox for trunk/src/VBox/Runtime

Timestamp:

Apr 22, 2008 12:13:16 PM (17 years ago)

Author:

vboxsync

Message:

Give VWRN_NUMBER_TOO_BIG highest priority among the warnings.

Location:

trunk/src/VBox/Runtime

Files:

• common/string/strtonum.cpp (modified) (12 diffs)
• testcase/tstStrToNum.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/strtonum.cpp

@@ -289 +289 @@
     uint64_t u64;
     int rc = RTStrToUInt64Ex(pszValue, ppszNext, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffffffffULL)
@@ -322 +322 @@
     uint64_t u64;
     int rc = RTStrToUInt64Full(pszValue, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffffffffULL)
@@ -373 +373 @@
     uint64_t u64;
     int rc = RTStrToUInt64Ex(pszValue, ppszNext, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffffULL)
@@ -406 +406 @@
     uint64_t u64;
     int rc = RTStrToUInt64Full(pszValue, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffffULL)
@@ -457 +457 @@
     uint64_t u64;
     int rc = RTStrToUInt64Ex(pszValue, ppszNext, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffULL)
@@ -490 +490 @@
     uint64_t u64;
     int rc = RTStrToUInt64Full(pszValue, uBase, &u64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         if (u64 & ~0xffULL)
@@ -716 +716 @@
     int64_t i64;
     int rc = RTStrToInt64Ex(pszValue, ppszNext, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int32_t i32 = (int32_t)i64;
@@ -749 +749 @@
     int64_t i64;
     int rc = RTStrToInt64Full(pszValue, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int32_t i32 = (int32_t)i64;
@@ -800 +800 @@
     int64_t i64;
     int rc = RTStrToInt64Ex(pszValue, ppszNext, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int16_t i16 = (int16_t)i64;
@@ -833 +833 @@
     int64_t i64;
     int rc = RTStrToInt64Full(pszValue, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int16_t i16 = (int16_t)i64;
@@ -884 +884 @@
     int64_t i64;
     int rc = RTStrToInt64Ex(pszValue, ppszNext, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int8_t i8 = (int8_t)i64;
@@ -917 +917 @@
     int64_t i64;
     int rc = RTStrToInt64Full(pszValue, uBase, &i64);
-    if (rc == VINF_SUCCESS)
+    if (RT_SUCCESS(rc))
     {
         int8_t i8 = (int8_t)i64;

trunk/src/VBox/Runtime/testcase/tstStrToNum.cpp

@@ -213 +213 @@
         { "0",                      0,  VINF_SUCCESS,           0 },
         { "1",                      0,  VINF_SUCCESS,           1 },
-        { "-1",                     0,  VWRN_NEGATIVE_UNSIGNED, ~0 },
+        /// @todo { "-1",                     0,  VWRN_NEGATIVE_UNSIGNED, ~0 }, - no longer true. bad idea?
+        { "-1",                     0,  VWRN_NUMBER_TOO_BIG,    ~0 },
         { "0x",                     0,  VWRN_TRAILING_CHARS,    0 },
         { "0x1",                    0,  VINF_SUCCESS,           1 },