Changeset 82837 in vbox for trunk/src/VBox/Runtime

Timestamp:

Jan 23, 2020 1:35:04 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135806

Message:

IPRT/file: Added some more thoughts and @todo regarding the RTFILE_O_APPEND situation. Updated flag docs. ticketref:19003

Location:

trunk/src/VBox/Runtime

Files:

• r3/win/fileio-win.cpp (modified) (1 diff)
• testcase/tstFile.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/fileio-win.cpp

@@ -935 +935 @@
 
     /*
-     * Change the EOF marker.  We may have to
+     * Change the EOF marker.
+     *
+     * HACK ALERT! If the file was opened in RTFILE_O_APPEND mode, we will have
+     *             to re-open it with FILE_WRITE_DATA access to get the job done.
+     *             This how ftruncate on a unixy system would work but not how
+     *             it is done on Windows where appending is a separate permission
+     *             rather than just a write modifier, making this hack totally wrong.
+     */
+    /** @todo The right way to fix this is either to add a RTFileSetSizeEx function
+     *        for specifically requesting the unixy behaviour, or add an additional
+     *        flag to RTFileOpen[Ex] to request the unixy append behaviour there.
+     *        The latter would require saving the open flags in a instance data
+     *        structure, which is a bit of a risky move, though something we should
+     *        do in 6.2 (or later).
+     *
+     *        Note! Because handle interitance, it is not realyan option to
+     *              always use FILE_WRITE_DATA and implement the RTFILE_O_APPEND
+     *              bits in RTFileWrite and friends.  Besides, it's not like
+     *              RTFILE_O_APPEND is so clearly defined anyway - see
+     *              RTFileWriteAt.
      */
     IO_STATUS_BLOCK Ios = RTNT_IO_STATUS_BLOCK_INITIALIZER;

trunk/src/VBox/Runtime/testcase/tstFile.cpp

@@ -78 +78 @@
 #if 1 //ndef RT_OS_WINDOWS
     /*
-     * Truncate the file and write some more. This is problematic on windows.
+     * Truncate the file and write some more. This is problematic on windows,
+     * we currently have a questionable hack in place to make this work.
      */
     RTTESTI_CHECK_RC_RETV(RTFileSetSize(hFile, 0), VINF_SUCCESS);